From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0083CC6FD18 for ; Wed, 29 Mar 2023 06:55:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjC2Gze (ORCPT ); Wed, 29 Mar 2023 02:55:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjC2Gzd (ORCPT ); Wed, 29 Mar 2023 02:55:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2F13211D for ; Tue, 28 Mar 2023 23:55:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9841B61AAF for ; Wed, 29 Mar 2023 06:55:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AABFAC433D2; Wed, 29 Mar 2023 06:55:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680072932; bh=gZdT6JvyRwdxiOTMO2uEuLb8hRR1RMi8JqsDlC+6i44=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vBo9NbAReDG1W0lNLKMfjnC+35NsTP42Pogb07XnaVJhkQk0JYmyNSn+Di31MrVmL 93X6h4vNbcv3izojkwoTFJ+Rf5XYPMGagn6MobYEmdTcVM/sSA5OSCO05q6HgDMtRP 9ln79dsopWzC6Eh7MO+JduKNDTfz1u6kTlzsO2gc= Date: Wed, 29 Mar 2023 08:55:29 +0200 From: Greg Kroah-Hartman To: Linyu Yuan Cc: linux-usb@vger.kernel.org Subject: Re: [PATCH v3 5/6] usb: gadget: f_fs: replace private pr_vdebug() with dev_vdbg Message-ID: References: <1679911940-4727-1-git-send-email-quic_linyyuan@quicinc.com> <1679911940-4727-5-git-send-email-quic_linyyuan@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1679911940-4727-5-git-send-email-quic_linyyuan@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Mar 27, 2023 at 06:12:19PM +0800, Linyu Yuan wrote: > Use command dev_vdbg() macro to show some debug message. > > Also replace some pr_debug/err/warn/info() to dev_dbg/err/warn/info(). > > Signed-off-by: Linyu Yuan > --- > v3: new patch in this version > > drivers/usb/gadget/function/f_fs.c | 98 +++++++++++++++++++------------------- > drivers/usb/gadget/function/u_fs.h | 6 --- > 2 files changed, 49 insertions(+), 55 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index 25461f1..0761eaa 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -317,12 +317,12 @@ static int __ffs_ep0_queue_wait(struct ffs_data *ffs, char *data, size_t len) > static int __ffs_ep0_stall(struct ffs_data *ffs) > { > if (ffs->ev.can_stall) { > - pr_vdebug("ep0 stall\n"); > + dev_vdbg(ffs->dev, "ep0 stall\n"); > usb_ep_set_halt(ffs->gadget->ep0); > ffs->setup_state = FFS_NO_SETUP; > return -EL2HLT; > } else { > - pr_debug("bogus ep0 stall!\n"); > + dev_dbg(ffs->dev, "bogus ep0 stall!\n"); > return -ESRCH; > } > } > @@ -361,7 +361,7 @@ static ssize_t ffs_ep0_write(struct file *file, const char __user *buf, > > /* Handle data */ > if (ffs->state == FFS_READ_DESCRIPTORS) { > - pr_info("read descriptors\n"); > + dev_info(ffs->dev, "read descriptors\n"); When a driver works properly, it should be quiet. Why is this driver being noisy for normal operations? Shouldn't these types of messages be moved to be debugging only? thanks, greg k-h