From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] usb: move config USB_USS720 to usb's misc Kconfig
Date: Wed, 29 Mar 2023 09:39:21 +0200 [thread overview]
Message-ID: <ZCPrKaIcsoj3Vvcs@kroah.com> (raw)
In-Reply-To: <20230329071724.11082-1-lukas.bulwahn@gmail.com>
On Wed, Mar 29, 2023 at 09:17:24AM +0200, Lukas Bulwahn wrote:
> The USS720 parport driver source code is in drivers/usb/misc/, the
> corresponding config is defined in drivers/usb/Kconfig. Some digging in the
> kernel's history revealed no good reason why it needs to be defined in
> USB's top-level Kconfig file, and why the config for the USS720 parport
> driver should be the first in the list of USB port drivers, while all other
> configs for drivers in drivers/usb/misc are in the USB Miscellaneous driver
> configuration file.
It is that way because this was one of the first USB drivers we had, and
we only had one Kconfig file at the time and no misc/ subdir in the usb
directory.
So it's just inertia, that's all.
Your change looks great to me, want to resend it without the RFC so that
I can apply it?
thanks,
greg k-h
next prev parent reply other threads:[~2023-03-29 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 7:17 [RFC PATCH] usb: move config USB_USS720 to usb's misc Kconfig Lukas Bulwahn
2023-03-29 7:39 ` Greg Kroah-Hartman [this message]
2023-03-29 7:55 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCPrKaIcsoj3Vvcs@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.