All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <simon.horman@corigine.com>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, gospo@broadcom.com,
	Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
	Pavan Chebbi <pavan.chebbi@broadcom.com>
Subject: Re: [PATCH net 2/3] bnxt_en: Fix typo in PCI id to device description string mapping
Date: Wed, 29 Mar 2023 15:08:44 +0200	[thread overview]
Message-ID: <ZCQ4XCOmE24jod9X@corigine.com> (raw)
In-Reply-To: <20230329013021.5205-3-michael.chan@broadcom.com>

On Tue, Mar 28, 2023 at 06:30:20PM -0700, Michael Chan wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> 
> Fix 57502 and 57508 NPAR description string entries.  The typos
> caused these devices to not match up with lspci output.
> 
> Fixes: 49c98421e6ab ("bnxt_en: Add PCI IDs for 57500 series NPAR devices.")
> Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

Note: I checked that this corresponds to
      https://pci-ids.ucw.cz/read/PC/14e4

> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index e2e2c986c82b..c23e3b397bcf 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -175,12 +175,12 @@ static const struct pci_device_id bnxt_pci_tbl[] = {
>  	{ PCI_VDEVICE(BROADCOM, 0x1750), .driver_data = BCM57508 },
>  	{ PCI_VDEVICE(BROADCOM, 0x1751), .driver_data = BCM57504 },
>  	{ PCI_VDEVICE(BROADCOM, 0x1752), .driver_data = BCM57502 },
> -	{ PCI_VDEVICE(BROADCOM, 0x1800), .driver_data = BCM57508_NPAR },
> +	{ PCI_VDEVICE(BROADCOM, 0x1800), .driver_data = BCM57502_NPAR },
>  	{ PCI_VDEVICE(BROADCOM, 0x1801), .driver_data = BCM57504_NPAR },
> -	{ PCI_VDEVICE(BROADCOM, 0x1802), .driver_data = BCM57502_NPAR },
> -	{ PCI_VDEVICE(BROADCOM, 0x1803), .driver_data = BCM57508_NPAR },
> +	{ PCI_VDEVICE(BROADCOM, 0x1802), .driver_data = BCM57508_NPAR },
> +	{ PCI_VDEVICE(BROADCOM, 0x1803), .driver_data = BCM57502_NPAR },
>  	{ PCI_VDEVICE(BROADCOM, 0x1804), .driver_data = BCM57504_NPAR },
> -	{ PCI_VDEVICE(BROADCOM, 0x1805), .driver_data = BCM57502_NPAR },
> +	{ PCI_VDEVICE(BROADCOM, 0x1805), .driver_data = BCM57508_NPAR },
>  	{ PCI_VDEVICE(BROADCOM, 0xd802), .driver_data = BCM58802 },
>  	{ PCI_VDEVICE(BROADCOM, 0xd804), .driver_data = BCM58804 },
>  #ifdef CONFIG_BNXT_SRIOV
> -- 
> 2.18.1
> 



  reply	other threads:[~2023-03-29 13:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29  1:30 [PATCH net 0/3] bnxt_en: 3 Bug fixes Michael Chan
2023-03-29  1:30 ` [PATCH net 1/3] bnxt_en: Fix reporting of test result in ethtool selftest Michael Chan
2023-03-29 13:08   ` Simon Horman
2023-03-29 17:34     ` Michael Chan
2023-03-29  1:30 ` [PATCH net 2/3] bnxt_en: Fix typo in PCI id to device description string mapping Michael Chan
2023-03-29 13:08   ` Simon Horman [this message]
2023-03-29  1:30 ` [PATCH net 3/3] bnxt_en: Add missing 200G link speed reporting Michael Chan
2023-03-29 13:19   ` Simon Horman
2023-03-30  4:50 ` [PATCH net 0/3] bnxt_en: 3 Bug fixes patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCQ4XCOmE24jod9X@corigine.com \
    --to=simon.horman@corigine.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gospo@broadcom.com \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.