From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kloudifold <cloudifold.3125@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev,
linux-staging@lists.linux.dev, alison.schofield@intel.com
Subject: Re: [PATCH v6] staging: sm750: Rename sm750_hw_cursor_* functions to snake_case
Date: Wed, 29 Mar 2023 13:42:54 +0200 [thread overview]
Message-ID: <ZCQkPr6t8IOvF6bk@kroah.com> (raw)
In-Reply-To: <ZCQeyWW3+d7+qT+b@CloudiRingWorld>
On Wed, Mar 29, 2023 at 07:27:04PM +0800, Kloudifold wrote:
> sm750 driver has sm750_hw_cursor_* functions, which are named in
> camelcase. Rename them to snake case to follow the function naming
> convention.
>
> - sm750_hw_cursor_setSize => sm750_hw_cursor_set_size
> - sm750_hw_cursor_setPos => sm750_hw_cursor_set_pos
> - sm750_hw_cursor_setColor => sm750_hw_cursor_set_color
> - sm750_hw_cursor_setData => sm750_hw_cursor_set_data
> - sm750_hw_cursor_setData2 => sm750_hw_cursor_set_data2
>
> Reported-by: kernel test robot <lkp@intel.com>
The test robot did not report that the names were incorrect :(
> Link: https://lore.kernel.org/oe-kbuild-all/202303110849.X24WnHnM-lkp@intel.com/
> Signed-off-by: Kloudifold <cloudifold.3125@gmail.com>
Is that the name you use to sign documents?
thanks,
greg k-h
next prev parent reply other threads:[~2023-03-29 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 11:27 [PATCH v6] staging: sm750: Rename sm750_hw_cursor_* functions to snake_case Kloudifold
2023-03-29 11:42 ` Greg Kroah-Hartman [this message]
2023-03-29 14:27 ` Kloudifold
2023-03-29 14:30 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCQkPr6t8IOvF6bk@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alison.schofield@intel.com \
--cc=cloudifold.3125@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.