From: Simon Horman <simon.horman@corigine.com>
To: Tom Rix <trix@redhat.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com,
petrm@nvidia.com, leon@kernel.org, shayagr@amazon.com,
wsa+renesas@sang-engineering.com, yangyingliang@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] net: ksz884x: remove unused change variable
Date: Wed, 29 Mar 2023 15:41:26 +0200 [thread overview]
Message-ID: <ZCRABhzLVCwfEgeQ@corigine.com> (raw)
In-Reply-To: <ZCQ70Rb311WzqPIJ@corigine.com>
On Wed, Mar 29, 2023 at 03:23:38PM +0200, Simon Horman wrote:
> On Wed, Mar 29, 2023 at 08:59:29AM -0400, Tom Rix wrote:
> > clang with W=1 reports
> > drivers/net/ethernet/micrel/ksz884x.c:3216:6: error: variable
> > 'change' set but not used [-Werror,-Wunused-but-set-variable]
> > int change = 0;
> > ^
> > This variable is not used so remove it.
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Hi Tom,
I notice a very large number of unused functions in ksz884x.c.
And I think this means some corresponding #defines can also be removed.
I'm wondering if you happen to be looking at this.
If not, I'll see about preparing a patch.
next prev parent reply other threads:[~2023-03-29 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 12:59 [PATCH] net: ksz884x: remove unused change variable Tom Rix
2023-03-29 13:23 ` Simon Horman
2023-03-29 13:41 ` Simon Horman [this message]
2023-03-31 6:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCRABhzLVCwfEgeQ@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shayagr@amazon.com \
--cc=trix@redhat.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.