From: Wolfram Sang <wsa@kernel.org>
To: Benjamin Bara <bbara93@gmail.com>
Cc: Lee Jones <lee@kernel.org>,
rafael.j.wysocki@intel.com, dmitry.osipenko@collabora.com,
jonathanh@nvidia.com, richard.leitner@linux.dev,
treding@nvidia.com, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
Benjamin Bara <benjamin.bara@skidata.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v3 2/4] i2c: core: run atomic i2c xfer when !preemptible
Date: Wed, 29 Mar 2023 21:50:42 +0200 [thread overview]
Message-ID: <ZCSWkhyQjnzByDoR@shikoro> (raw)
In-Reply-To: <CAJpcXm6bt100442y8ajz7kR0nF3Gm9PVVwo3EKVBDC4Pmd-7Ag@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
On Mon, Mar 27, 2023 at 06:23:24PM +0200, Benjamin Bara wrote:
> On Mon, 27 Mar 2023 at 16:54, Wolfram Sang <wsa@kernel.org> wrote:
> > For the !CONFIG_PREEMPT_COUNT case, preemptible() is defined 0. So,
> > don't we lose the irqs_disabled() check in that case?
>
> Thanks for the feedback!
> PREEMPT_COUNT is selected by PREEMPTION, so I guess in the case of
> !PREEMPT_COUNT,
> we should be atomic (anyways)?
Could you make sure please? Asking Peter Zijlstra might be a good idea.
He helped me with the current implementation.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-03-29 19:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 13:57 [PATCH v3 0/4] mfd: tps6586x: register restart handler Benjamin Bara
2023-03-27 13:57 ` [PATCH v3 1/4] kernel/reboot: emergency_restart: set correct system_state Benjamin Bara
2023-03-27 13:57 ` [PATCH v3 2/4] i2c: core: run atomic i2c xfer when !preemptible Benjamin Bara
2023-03-27 14:54 ` Wolfram Sang
2023-03-27 16:23 ` Benjamin Bara
2023-03-29 19:50 ` Wolfram Sang [this message]
2023-04-02 10:04 ` Benjamin Bara
2023-04-04 8:22 ` Peter Zijlstra
2023-04-04 14:06 ` Benjamin Bara
2023-03-27 13:57 ` [PATCH v3 3/4] mfd: tps6586x: use devm-based power off handler Benjamin Bara
2023-04-02 22:28 ` Dmitry Osipenko
2023-03-27 13:57 ` [PATCH v3 4/4] mfd: tps6586x: register restart handler Benjamin Bara
2023-04-02 22:30 ` Dmitry Osipenko
2023-04-03 6:50 ` Benjamin Bara
2023-04-03 15:44 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCSWkhyQjnzByDoR@shikoro \
--to=wsa@kernel.org \
--cc=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=dmitry.osipenko@collabora.com \
--cc=jonathanh@nvidia.com \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=richard.leitner@linux.dev \
--cc=stable@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.