All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 1/3] x86: Add define for MSR_IA32_PRED_CMD's PRED_CMD_IBPB (bit 0)
Date: Wed, 29 Mar 2023 20:44:33 -0700	[thread overview]
Message-ID: <ZCUFoeqONfWU1+D1@google.com> (raw)
In-Reply-To: <49dd4ae8-9b7a-b6ce-ee9b-3ba76b12c06e@intel.com>

On Thu, Mar 30, 2023, Xiaoyao Li wrote:
> On 3/30/2023 12:36 AM, Sean Christopherson wrote:
> > On Wed, Mar 29, 2023, Xiaoyao Li wrote:
> > > On 3/28/2023 11:07 PM, Sean Christopherson wrote:
> > > > On Tue, Mar 28, 2023, Xiaoyao Li wrote:
> > > > > On 3/28/2023 1:02 PM, Sean Christopherson wrote:
> > > > > > Add a define for PRED_CMD_IBPB and use it to replace the open coded '1' in
> > > > > > the nVMX library.
> > > > > What does nVMX mean here?
> > > > Nested VMX.  From KUT's perspective, the testing exists to validate KVM's nested
> > > > VMX implementation.  If it's at all confusing, I'll drop the 'n'  And we've already
> > > > established that KUT can be used on bare metal, even if that's not the primary use
> > > > case.
> > > So vmexit.flat is supposed to be ran in L1 VM?
> > Not all of the tests can be run on bare metal, e.g. I can't imagine the VMware
> > backdoor test works either.
> > 
> 
> Sorry, I think neither I ask clearly nor you got my point.
> 
> You said "the testing exists to validate KVM's nested VMX implementation".
> So I want to know what's the expected usage to run vmexit.flat.
> 
> If for nested, we need to first boot a VM and then inside the VM we run the
> vmexit.flat with QEMU, right?
> 
> That's what confuses me. Isn't vmexit.flat supposed to be directly used on
> the host with QEMU? In this case, nothing to do with nested.

Oof, my bad, I had a literacy problem.  I somehow read "vmx.c" instead of "vmexit.c",
and never picked up on what you were saying.  I'll fix the changelog.

  reply	other threads:[~2023-03-30  3:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28  5:02 [kvm-unit-tests PATCH 0/3] x86/msr: Add tests for command MSRs Sean Christopherson
2023-03-28  5:02 ` [kvm-unit-tests PATCH 1/3] x86: Add define for MSR_IA32_PRED_CMD's PRED_CMD_IBPB (bit 0) Sean Christopherson
2023-03-28  7:02   ` Xiaoyao Li
2023-03-28 15:07     ` Sean Christopherson
2023-03-29  4:46       ` Xiaoyao Li
2023-03-29 16:36         ` Sean Christopherson
2023-03-30  1:05           ` Xiaoyao Li
2023-03-30  3:44             ` Sean Christopherson [this message]
2023-03-28  5:02 ` [kvm-unit-tests PATCH 2/3] x86/msr: Add testcases for MSR_IA32_PRED_CMD and its IBPB command Sean Christopherson
2023-04-12 19:26   ` Paolo Bonzini
2023-03-28  5:02 ` [kvm-unit-tests PATCH 3/3] x86/msr: Add testcases for MSR_IA32_FLUSH_CMD and its L1D_FLUSH command Sean Christopherson
2023-04-05 23:00 ` [kvm-unit-tests PATCH 0/3] x86/msr: Add tests for command MSRs Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCUFoeqONfWU1+D1@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.