From: Johannes Weiner <hannes@cmpxchg.org>
To: Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ke.wang@unisoc.com
Subject: Re: [PATCH] mm: mark folio as workingset in lru_deactivate_fn
Date: Thu, 30 Mar 2023 05:32:04 -0400 [thread overview]
Message-ID: <ZCVXFLA+sarzGG18@cmpxchg.org> (raw)
In-Reply-To: <CAGWkznFRHbYv2ev3FU10zapka_6MDQ+g_-b0jufzqcAEAKUqFA@mail.gmail.com>
On Thu, Mar 30, 2023 at 09:38:48AM +0800, Zhaoyang Huang wrote:
> On Wed, Mar 29, 2023 at 10:55 PM Johannes Weiner <hannes@cmpxchg.org> wrote:
> >
> > On Wed, Mar 29, 2023 at 06:47:35PM +0800, zhaoyang.huang wrote:
> > > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> > >
> > > folio will skip of being set as workingset in lru_deactivate_fn.
> >
> > Can you please elaborate why that's undesirable? What's the problem
> > you're fixing?
> If I am correct, folio will skip being set as workingset when moving
> from active lru to inactive lru, which is performed on every folio in
> shrink_active_list during normal reclaim.
shrink_active_list directly calls folio_set_workingset(). The function
you're editing is used for things like MADV_COLD and truncate().
It sounds like there is just a misunderstanding of the code, not an
actual problem.
next prev parent reply other threads:[~2023-03-30 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 10:47 [PATCH] mm: mark folio as workingset in lru_deactivate_fn zhaoyang.huang
2023-03-29 14:55 ` Johannes Weiner
2023-03-30 1:38 ` Zhaoyang Huang
2023-03-30 9:32 ` Johannes Weiner [this message]
2023-03-30 9:41 ` Zhaoyang Huang
2023-04-03 8:18 ` Zhaoyang Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCVXFLA+sarzGG18@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=huangzhaoyang@gmail.com \
--cc=ke.wang@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.