From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Feng Tang <feng.tang@intel.com>, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Joe Mario <jmario@redhat.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Eric Dumazet <edumazet@google.com>,
dave.hansen@intel.com, ying.huang@intel.com,
tim.c.chen@intel.com, andi.kleen@intel.com
Subject: Re: [PATCH v2] Documentation: Add document for false sharing
Date: Thu, 30 Mar 2023 21:05:05 +0700 [thread overview]
Message-ID: <ZCWXET8MPoyUc/Md@debian.me> (raw)
In-Reply-To: <CALvZod48Fwua_VJvnzHatF-J4YRWqfMFnYjYN6W0_ioLtPZEfA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
On Wed, Mar 29, 2023 at 09:51:56PM -0700, Shakeel Butt wrote:
> > > +* Turn hot global data to 'per-cpu data + global data' when possible,
> > > + or reasonably increase the threshold for syncing per-cpu data to
> > > + global data, to reduce or postpone the 'write' to that global data.
> > > +
> > > + - Commit 520f897a3554 ("ext4: use percpu_counters for extent_status cache hits/misses")
> > > + - Commit 56f3547bfa4d ("mm: adjust vm_committed_as_batch according to vm overcommit policy")
> > > +
> >
> > Here's what I mean by bridging conjunctions to example commits as I reviewed
> > in v1 [1]:
> >
>
> This is too much and unneeded nitpicking. The patch looks good as is.
As ESL people, I feel there is a gap when a description paragraph is
followed immediately by some sort of lists without bridging (conjunction
between them). I expect a smooth transition in this case. Even though
before the list it is written "(with examples)", I think the conjunction
is needed anyway.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-03-30 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 7:33 [PATCH v2] Documentation: Add document for false sharing Feng Tang
2023-03-30 4:27 ` Bagas Sanjaya
2023-03-30 4:51 ` Shakeel Butt
2023-03-30 13:41 ` Jonathan Corbet
2023-04-03 14:07 ` Feng Tang
2023-03-30 14:05 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCWXET8MPoyUc/Md@debian.me \
--to=bagasdotme@gmail.com \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@intel.com \
--cc=edumazet@google.com \
--cc=feng.tang@intel.com \
--cc=jmario@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=shakeelb@google.com \
--cc=tim.c.chen@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.