Re: [PATCH] RDMA: Add ib_virt_dma_to_page()

[Jason Gunthorpe <jgg@nvidia.com>]

On Thu, Mar 30, 2023 at 11:53:52PM +0200, Linus Walleij wrote:
> On Thu, Mar 30, 2023 at 9:02 PM kernel test robot <lkp@intel.com> wrote:
> 
> > 0d1b756acf60da Linus Walleij   2022-09-02  536                                  /*
> > 0d1b756acf60da Linus Walleij   2022-09-02  537                                   * Cast to an uintptr_t to preserve all 64 bits
> > 0d1b756acf60da Linus Walleij   2022-09-02  538                                   * in sge->laddr.
> > 0d1b756acf60da Linus Walleij   2022-09-02  539                                   */
> > a10308d393288b Jason Gunthorpe 2023-03-30  540                                  u64 va = (uintptr_t)(sge->laddr + sge_off);
> 
> Oh now that becomes an u64
> 
> > b9be6f18cf9ed0 Bernard Metzler 2019-06-20  541
> > a10308d393288b Jason Gunthorpe 2023-03-30  542                                  page_array[seg] = ib_virt_dma_to_page(va);
> > b9be6f18cf9ed0 Bernard Metzler 2019-06-20  543                                  if (do_crc)
> > b9be6f18cf9ed0 Bernard Metzler 2019-06-20  544                                          crypto_shash_update(
> > b9be6f18cf9ed0 Bernard Metzler 2019-06-20  545                                                  c_tx->mpa_crc_hd,
> > 0d1b756acf60da Linus Walleij   2022-09-02 @546                                                  (void *)va,
> 
> Then this cast needs to be (void *)(uintptr_t) again.
> 
> Not very elegant, possibly something more smooth can be done.

It needs another similar helper function to from dma_addr to kva void *

Jason