From: Christoph Hellwig <hch@infradead.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Pankaj Raghav <p.raghav@samsung.com>,
martin@omnibond.com, axboe@kernel.dk, akpm@linux-foundation.org,
hubcap@omnibond.com, willy@infradead.org,
viro@zeniv.linux.org.uk, senozhatsky@chromium.org,
brauner@kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, mcgrof@kernel.org,
linux-block@vger.kernel.org, gost.dev@samsung.com,
linux-mm@kvack.org, devel@lists.orangefs.org
Subject: Re: [PATCH 1/5] zram: remove the call to page_endio in the bio end_io handler
Date: Thu, 30 Mar 2023 16:16:25 -0700 [thread overview]
Message-ID: <ZCYYSdpmWRJynC6d@infradead.org> (raw)
In-Reply-To: <ZCYSincU0FlULyWJ@google.com>
On Thu, Mar 30, 2023 at 03:51:54PM -0700, Minchan Kim wrote:
> > to remove the call to page_endio() function that unlocks or marks
> > writeback end on the page.
> >
> > Rename the endio handler from zram_page_end_io to zram_read_end_io as
> > the call to page_endio() is removed and to associate the callback to the
> > operation it is used in.
>
> Since zram removed the rw_page and IO comes with bio from now on,
> IIUC, we are fine since every IO will go with chained-IO. Right?
writeback_store callszram_bvec_read with a NULL bio, that is it just
fires off an async read without any synchronization.
next prev parent reply other threads:[~2023-03-30 23:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230328112717eucas1p2eb9395b7e3334c08aa28740b0af46fe9@eucas1p2.samsung.com>
2023-03-28 11:27 ` [PATCH 0/5] remove page_endio() Pankaj Raghav
2023-03-28 11:27 ` [PATCH 1/5] zram: remove the call to page_endio in the bio end_io handler Pankaj Raghav
2023-03-28 15:19 ` Matthew Wilcox
2023-03-28 16:17 ` Pankaj Raghav
2023-03-29 23:53 ` Christoph Hellwig
2023-03-30 22:51 ` Minchan Kim
2023-03-30 23:16 ` Christoph Hellwig [this message]
2023-03-31 1:42 ` Minchan Kim
2023-03-31 11:19 ` Pankaj Raghav
2023-03-28 11:27 ` [PATCH 2/5] orangefs: use folios in orangefs_readahead Pankaj Raghav
2023-03-28 15:21 ` Matthew Wilcox
2023-03-28 16:02 ` Pankaj Raghav
2023-03-29 19:10 ` Mike Marshall
2023-03-28 11:27 ` [PATCH 3/5] mpage: split bi_end_io callback for reads and writes Pankaj Raghav
2023-03-28 11:27 ` [PATCH 4/5] mpage: use folios in bio end_io handler Pankaj Raghav
2023-03-28 11:27 ` [PATCH 5/5] filemap: remove page_endio() Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCYYSdpmWRJynC6d@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=gost.dev@samsung.com \
--cc=hubcap@omnibond.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin@omnibond.com \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=p.raghav@samsung.com \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.