All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Mason <jdmason@kudzu.us>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: meta-arm@lists.yoctoproject.org
Subject: Re: [PATCH 1/2] arm/lib: pass the PATH to fvp runner
Date: Thu, 30 Mar 2023 23:01:07 -0400	[thread overview]
Message-ID: <ZCZM88HRz0zDSqUk@kudzu.us> (raw)
In-Reply-To: <20230329120057.58949-1-peron.clem@gmail.com>

On Wed, Mar 29, 2023 at 02:00:56PM +0200, Cl�ment P�ron wrote:
> When running an FVP machine the model executable need to be found
> in the PATH environement.
> 
> At the moment the script doesn't provide any PATH to the subprocess.
> 
> Add PATH to the allowed environement variable to be forwaded.
> 
> Signed-off-by: Cl�ment P�ron <peron.clem@gmail.com>

This patch doesn't apply cleanly to the master branch.  I think it's
as simple as appending to the list of variables passed to the
environment, but I'll leave it to you to confirm and test.

Thanks,
Jon

> ---
>  meta-arm/lib/fvp/runner.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-arm/lib/fvp/runner.py b/meta-arm/lib/fvp/runner.py
> index 28351a39..40ad1f3c 100644
> --- a/meta-arm/lib/fvp/runner.py
> +++ b/meta-arm/lib/fvp/runner.py
> @@ -63,7 +63,7 @@ class FVPRunner:
>          # Pass through environment variables needed for GUI applications, such
>          # as xterm, to work.
>          env = config['env']
> -        for name in ('DISPLAY', 'WAYLAND_DISPLAY'):
> +        for name in ('DISPLAY', 'PATH', 'WAYLAND_DISPLAY'):
>              if name in os.environ:
>                  env[name] = os.environ[name]
>  
> -- 
> 2.34.1
> 
> 


  parent reply	other threads:[~2023-03-31  3:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 12:00 [PATCH 1/2] arm/lib: pass the PATH to fvp runner Clément Péron
2023-03-29 12:00 ` [PATCH 2/2] scripts/runfvp: Fix KeyError exception when there is no FVP_CONSOLE provided Clément Péron
2023-03-29 15:42   ` [meta-arm] " Peter Hoyes
2023-03-31  3:01 ` Jon Mason [this message]
2023-03-31 20:11   ` [PATCH 1/2] arm/lib: pass the PATH to fvp runner Jon Mason
2023-05-25  0:51 ` Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCZM88HRz0zDSqUk@kudzu.us \
    --to=jdmason@kudzu.us \
    --cc=meta-arm@lists.yoctoproject.org \
    --cc=peron.clem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.