From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93CCC8F54 for ; Fri, 31 Mar 2023 22:24:07 +0000 (UTC) Received: by mail-qv1-f50.google.com with SMTP id dw2so240067qvb.11 for ; Fri, 31 Mar 2023 15:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680301446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=WtftlvxQJ039HPxSLQblKHBrwyQ77QzbzDmRY3gJhwU=; b=Ctn+GnX1rq1Z7HSzKakAN5zxRYXrz1UW4nISkjn0Vnb4KaVx+Ycx+g7RWTQ2ZW7Uw9 IizLYZ5zcA7xeP8wr7jSn6Fd5BlZdHJIwUabFbnC+tZ1ddWK+TfLXnIkty6d+9vg1bvC bDAqtDu31uLhWoqDX2B75cO+Pqo4C120ZoGCytBzTgsSo20w9qa5/IL1RqM+gqn8vrSu q4LBsvjd2x1IN2QzifFIM/E8WUbPDmBokkaR+0ZamLEc+F8Q1GrsPqn4DXhzPAeHUeOY Z8+LT7OI0khd9kXHlVoTI5di2vSsNr0ApgqJvjm5p22eYdrZtti+gIaJ/o4bWoI4Yatj 6xCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680301446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WtftlvxQJ039HPxSLQblKHBrwyQ77QzbzDmRY3gJhwU=; b=y4dqpFkg0nqCYXuTO7YAUn2NTiElEOF2NLLfD7h8idsWvEz7OPhPVVFw15gB+KBSH1 BP2TQ4JD9Bk1f8Y/MrNsl5uhFHmjzpda75RVL7XB8WAJgBm/7QnagSwb+C+EehNC3fBN oFOcQ0V5EiUzO4toytXHt5YXw6g+wdiQ3utdht54L2fbAon7/ToAAp3ISyvlvCdXltSx ByN47r17/Hej3VK2rkgZ6IuJQFCNL/3Hl9a1D32vFzgdehWlju3C9DcmSzXUe3M0XFo8 qaokOvC3QX6BWBXff0dZ9BOreTbM4w9mOP8rEe7vgb/K2ZYJcfJFlQO1AKPu+0fO1j3e bBGA== X-Gm-Message-State: AAQBX9cRJZaJcVX68WL5z9HnAQzcubV+pZDEce5LBKHzBENSbg8QI4jF 1TAAeLAAJFKiWBCWv04GikI= X-Google-Smtp-Source: AKy350aYKxU1nt9CaIHh9UA5sMMVmy62LYl/MTSN9NDTiDP/B3htWeBAUOlUh6tpfYXRtuzh/jLq9w== X-Received: by 2002:ad4:5ca7:0:b0:5cc:e059:efa3 with SMTP id q7-20020ad45ca7000000b005cce059efa3mr47450729qvh.23.1680301446517; Fri, 31 Mar 2023 15:24:06 -0700 (PDT) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id g10-20020a0cfdca000000b005dd8b9345d2sm873652qvs.106.2023.03.31.15.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 15:24:06 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 8C69427C0054; Fri, 31 Mar 2023 18:24:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 31 Mar 2023 18:24:05 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeivddgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhu nhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpeehudfgudffffetuedtvdehueevledvhfelleeivedtgeeuhfegueeviedu ffeivdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gsohhquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeiledvgeehtdei gedqudejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmhgrihhlrdgtohhmsehfih igmhgvrdhnrghmvg X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 31 Mar 2023 18:24:04 -0400 (EDT) Date: Fri, 31 Mar 2023 15:23:17 -0700 From: Boqun Feng To: y86-dev@protonmail.com Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Alice Ryhl , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andreas Hindborg , Alice Ryhl Subject: Re: [PATCH v4 01/15] rust: enable the `pin_macro` feature Message-ID: References: <20230331215053.585759-1-y86-dev@protonmail.com> <20230331215053.585759-2-y86-dev@protonmail.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 31, 2023 at 02:52:18PM -0700, Boqun Feng wrote: > On Fri, Mar 31, 2023 at 09:51:35PM +0000, y86-dev@protonmail.com wrote: > > From: Benno Lossin > > > > This feature enables the use of the `pin!` macro for the `stack_pin_init!` > > macro. This feature is already stabilized in Rust version 1.68. > > > > Signed-off-by: Benno Lossin > > Cc: Gary Guo > > Cc: Andreas Hindborg > > Cc: Alice Ryhl > > Acked-by: Boqun Feng > Hmm.. actually I think you will need to add this in the scripts/Makefile.build, because the user (stack_pin_init!()) is a macro, feel free to add my acked-by after that. Regards, Boqun > Regards, > Boqun > > > --- > > rust/kernel/lib.rs | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs > > index 223564f9f0cc..4317b6d5f50b 100644 > > --- a/rust/kernel/lib.rs > > +++ b/rust/kernel/lib.rs > > @@ -17,6 +17,7 @@ > > #![feature(core_ffi_c)] > > #![feature(dispatch_from_dyn)] > > #![feature(generic_associated_types)] > > +#![feature(pin_macro)] > > #![feature(receiver_trait)] > > #![feature(unsize)] > > > > -- > > 2.39.2 > > > >