From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EDF1C77B60 for ; Sun, 2 Apr 2023 08:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230133AbjDBIAL (ORCPT ); Sun, 2 Apr 2023 04:00:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjDBIAL (ORCPT ); Sun, 2 Apr 2023 04:00:11 -0400 Received: from 1wt.eu (wtarreau.pck.nerim.net [62.212.114.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 06F3FFF0D; Sun, 2 Apr 2023 01:00:09 -0700 (PDT) Received: (from willy@localhost) by mail.home.local (8.17.1/8.17.1/Submit) id 332805sn018362; Sun, 2 Apr 2023 10:00:05 +0200 Date: Sun, 2 Apr 2023 10:00:05 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 3/3] tools/nolibc: add testcases for vfprintf Message-ID: References: <20230328-nolibc-printf-test-v1-0-d7290ec893dd@weissschuh.net> <20230328-nolibc-printf-test-v1-3-d7290ec893dd@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230328-nolibc-printf-test-v1-3-d7290ec893dd@weissschuh.net> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, Mar 28, 2023 at 09:01:31PM +0000, Thomas Weißschuh wrote: > + fd = memfd_create("vfprintf", 0); > + if (fd == -1) { > + pad_spc(llen, 64, "[FAIL]\n"); > + return 1; > + } Also for this you'll need to include in the part where nolibc is not detected so that it continues to work with regular libcs (at least glibc so that we have one reference to compare against). Thanks, Willy