From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA57DC76196 for ; Mon, 3 Apr 2023 09:59:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9DFA685827; Mon, 3 Apr 2023 11:59:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="XMuG4+JI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 72C5185E3D; Mon, 3 Apr 2023 11:59:13 +0200 (CEST) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E3BA685D13 for ; Mon, 3 Apr 2023 11:59:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x535.google.com with SMTP id r11so114981751edd.5 for ; Mon, 03 Apr 2023 02:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680515949; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=704PGPUjJLntFMSEECYMPlYsclMgwQMP2ZXiWFGDuYw=; b=XMuG4+JIopNsQZAsRfqtobJt6JxvSm2qzAvAQro8YpO3Dg7MBX9BA+xbfxsBBMA29C kRRuPBtibXNvqsJDMSmt8lGwOxDvcYBlxEJc+fpjlw9R24bBZf+yEZaKDS4m8fn0ofWM GN4tEWlaPUMoLmx2WZ+nwTgSBLEondGlFyKfKeXCrKkY6C0aCbwxN4NuT/n478dXXzwa OOhJC3/jfpnf6SmrXI79XYrudYJAjwopMni6SLr50eGJvA3gB72xgqcqh/pi3THQ2dxb BmFX/WPwe6nV0q095WMuyRD3rVbmI6FVP+TefwbUf1xLcO0uQB/xb/bj9vh+yQ3QIisv qJfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680515949; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=704PGPUjJLntFMSEECYMPlYsclMgwQMP2ZXiWFGDuYw=; b=ry2dSJr+HNb0YoDC4l6ZMqrQcRA0o7XcpaSUWz+McXcpfElMIuuHosnPpC7/Qr6diI dxvbuOgFihoq54lZL7uMLG68/hxd+zemR018podyFGFj63qinWoz9kaykVmjXQZGEK5+ JwtSyeHn1tbZx/JAvXNVU26PQFgLsK7xn6hF6KxKRUxyti78L+LFdiGMny0sbdRm5LaO ZDUo8ok328hlZKDdYGT9DnriHiMrkzLW9uhER1If7r7UVZmOeBLgzYXuSw1O3FcsXgVE O5kH9RJsApsqx84dZoejD1iDj+P4WeAJDYkwA5dd8Wu4VZcw6gqt8L+n5wE2PazYfpsI nHbA== X-Gm-Message-State: AAQBX9ceCWxfAdF/ek5bP783U/YTVDVPQELNiKLVSC6g4+2WhCGpUiGA a3yU6AIL1hEg16/Ou9zmCCXE8A== X-Google-Smtp-Source: AKy350bwtznOQ856VlAhH9KfWKXcw6sQ6V8F8lOAd5617mX927zmPUo/+ACXVeTbZhKyaruRueXrXw== X-Received: by 2002:a17:906:175a:b0:92c:8e4a:1a42 with SMTP id d26-20020a170906175a00b0092c8e4a1a42mr38002097eje.32.1680515949520; Mon, 03 Apr 2023 02:59:09 -0700 (PDT) Received: from hera (ppp176092130041.access.hol.gr. [176.92.130.41]) by smtp.gmail.com with ESMTPSA id dx7-20020a170906a84700b008d53ea69227sm4313688ejb.224.2023.04.03.02.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 02:59:09 -0700 (PDT) Date: Mon, 3 Apr 2023 12:59:06 +0300 From: Ilias Apalodimas To: Simon Glass Cc: Abdellatif El Khlifi , Drew.Reed@arm.com, achin.gupta@arm.com, Jens Wiklander , nd , Rob Herring , Sudeep Holla , Tom Rini , U-Boot Mailing List , Xueliang Zhong Subject: Re: [PATCH v10 10/10] arm_ffa: efi: corstone1000: enable MM communication Message-ID: References: <20230328161157.219375-1-abdellatif.elkhlifi@arm.com> <20230328161157.219375-11-abdellatif.elkhlifi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sun, Apr 02, 2023 at 02:41:17PM +1200, Simon Glass wrote: > Hi Abdellatif, > > On Wed, 29 Mar 2023 at 05:12, Abdellatif El Khlifi < > abdellatif.elkhlifi@arm.com> wrote: > > > > turn on EFI MM communication > > > > On corstone1000 platform MM communication between u-boot > > and the secure world (Optee) is done using the FF-A bus. > > > > Signed-off-by: Abdellatif El Khlifi > > Cc: Tom Rini > > Cc: Simon Glass > > Cc: Ilias Apalodimas > > Cc: Jens Wiklander > > > > --- > > Changelog: > > =============== > > > > v9: update copyright string > > > > v8: > > > > * drop OP-TEE configs from Corstone-1000 defconfig > > > > v7: > > > > * improve the definition of FFA_SHARED_MM_BUFFER_ADDR and > > FFA_SHARED_MM_BUFFER_OFFSET > > * update FFA_SHARED_MM_BUFFER_ADDR value > > > > v6: > > > > * corstone-1000: enable optee driver > > * corstone-1000: remove CONFIG_ARM_FFA_EFI_RUNTIME_MODE from the defconfig > > > > v4: > > > > * corstone-1000: turn on EFI MM communication > > > > configs/corstone1000_defconfig | 2 ++ > > include/configs/corstone1000.h | 15 +++++++++++++-- > > 2 files changed, 15 insertions(+), 2 deletions(-) > > > > diff --git a/configs/corstone1000_defconfig > b/configs/corstone1000_defconfig > > index 74250c7524..a7bfcbb2b9 100644 > > --- a/configs/corstone1000_defconfig > > +++ b/configs/corstone1000_defconfig > > @@ -52,3 +52,5 @@ CONFIG_DM_SERIAL=y > > CONFIG_USB=y > > CONFIG_USB_ISP1760=y > > CONFIG_ERRNO_STR=y > > +CONFIG_EFI_MM_COMM_TEE=y > > +CONFIG_ARM_FFA_TRANSPORT=y > > diff --git a/include/configs/corstone1000.h > b/include/configs/corstone1000.h > > index 3347c11792..4ef1f05e40 100644 > > --- a/include/configs/corstone1000.h > > +++ b/include/configs/corstone1000.h > > @@ -1,9 +1,11 @@ > > /* SPDX-License-Identifier: GPL-2.0+ */ > > /* > > - * (C) Copyright 2022 ARM Limited > > * (C) Copyright 2022 Linaro > > * Rui Miguel Silva > > - * Abdellatif El Khlifi > > + * Copyright 2022-2023 Arm Limited and/or its affiliates < > open-source-office@arm.com> > > + * > > + * Authors: > > + * Abdellatif El Khlifi > > * > > * Configuration for Corstone1000. Parts were derived from other ARM > > * configurations. > > @@ -14,6 +16,15 @@ > > > > #include > > > > +#define FFA_SHARED_MM_BUFFER_SIZE SZ_4K /* 4 KB */ > > + > > +/* > > + * shared buffer physical address used for communication between > > + * u-boot and the MM SP > > + */ > > +#define FFA_SHARED_MM_BUFFER_ADDR 0x02000000UL > > +#define FFA_SHARED_MM_BUFFER_OFFSET 0 > > + > > #define V2M_BASE 0x80000000 > > > > #define CFG_PL011_CLOCK 50000000 > > -- > > 2.25.1 > > > > As a higher-level question, could this whole FFA implementation code be put > into Linux or fwupd? Hi Simon, FF-A is basically a communication mechanism between the secure and non-secure world for Arm. Linux has support for it. fwupd should be completely agnostic to the protocol Regards /Ilias > > Regards, > Simon