From: Simon Horman <simon.horman@corigine.com>
To: Zahari Doychev <zahari.doychev@linux.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
hmehrtens@maxlinear.com, aleksander.lobakin@intel.com,
Zahari Doychev <zdoychev@maxlinear.com>
Subject: Re: [PATCH net-next v2 1/2] net: flower: add support for matching cfm fields
Date: Mon, 3 Apr 2023 17:51:36 +0200 [thread overview]
Message-ID: <ZCr2CNNhfwLrlg3j@corigine.com> (raw)
In-Reply-To: <fokufd5lc6mcexzte3x22dfd4x4sdjo3i24tjucdolfwmrx2au@3l45wabn7cuz>
On Mon, Apr 03, 2023 at 05:36:22PM +0200, Zahari Doychev wrote:
> On Mon, Apr 03, 2023 at 04:54:12PM +0200, Simon Horman wrote:
> > On Sun, Apr 02, 2023 at 05:10:30PM +0200, Zahari Doychev wrote:
> > > From: Zahari Doychev <zdoychev@maxlinear.com>
...
> > > @@ -1390,6 +1413,12 @@ bool __skb_flow_dissect(const struct net *net,
> > > break;
> > > }
> > >
> > > + case htons(ETH_P_CFM): {
> > > + fdret = __skb_flow_dissect_cfm(skb, flow_dissector,
> > > + target_container, data,
> > > + nhoff, hlen);
> >
> > I do like that you moved the handling into it's own function.
> > But I do also note that this style differs from adjacent code in this
> > file.
>
> I would prefer to have an own function here as I find __skb_flow_dissect
> long enough already. But if you insist I am okay to change it.
I don't insist.
I like it the way it is.
next prev parent reply other threads:[~2023-04-03 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 15:10 [PATCH net-next v2 0/2] net: flower: add cfm support Zahari Doychev
2023-04-02 15:10 ` [PATCH net-next v2 1/2] net: flower: add support for matching cfm fields Zahari Doychev
2023-04-03 14:54 ` Simon Horman
2023-04-03 15:36 ` Zahari Doychev
2023-04-03 15:51 ` Simon Horman [this message]
2023-04-02 15:10 ` [PATCH net-next v2 2/2] selftests: net: add tc flower cfm test Zahari Doychev
2023-04-03 13:31 ` Simon Horman
2023-04-03 15:37 ` Zahari Doychev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCr2CNNhfwLrlg3j@corigine.com \
--to=simon.horman@corigine.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hmehrtens@maxlinear.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
--cc=zahari.doychev@linux.com \
--cc=zdoychev@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.