All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Sushil Singh <sushilkumars@nvidia.com>
Cc: treding@nvidia.com, jonathanh@nvidia.com,
	linux-tegra@vger.kernel.org, vbhadram@nvidia.com
Subject: Re: [PATCH V2] soc/tegra: pmc: Add wake source interrupt for MGBE
Date: Mon, 3 Apr 2023 14:37:49 +0200	[thread overview]
Message-ID: <ZCrIna6vM7T4m-wc@orome> (raw)
In-Reply-To: <1679577204-8304-1-git-send-email-sushilkumars@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]

On Thu, Mar 23, 2023 at 06:43:24PM +0530, Sushil Singh wrote:
> Add the GPIO wake interrupt for MGBE ethernet controller on Tegra234 SoC.
> 
> Signed-off-by: Sushil Singh <sushilkumars@nvidia.com>
> ---
> 
> Changes in v2:
> Address Jonathan's comments
> Rewrite the commit description
> Use "mgbe" instead of "mgbe_wake"
> 
>  drivers/soc/tegra/pmc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index cf4cfbf..0f3c472 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -3,7 +3,7 @@
>   * drivers/soc/tegra/pmc.c
>   *
>   * Copyright (c) 2010 Google, Inc
> - * Copyright (c) 2018-2022, NVIDIA CORPORATION. All rights reserved.
> + * Copyright (c) 2018-2023, NVIDIA CORPORATION. All rights reserved.
>   *
>   * Author:
>   *	Colin Cross <ccross@google.com>
> @@ -4227,6 +4227,7 @@ static const char * const tegra234_reset_sources[] = {
>  static const struct tegra_wake_event tegra234_wake_events[] = {
>  	TEGRA_WAKE_GPIO("power", 29, 1, TEGRA234_AON_GPIO(EE, 4)),
>  	TEGRA_WAKE_IRQ("rtc", 73, 10),
> +	TEGRA_WAKE_GPIO("mgbe", 56, 0, TEGRA234_MAIN_GPIO(Y, 3)),
>  };

Applied, though I did sort this into the right place (these are ordered
by wake number).

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2023-04-03 12:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 13:13 [PATCH V2] soc/tegra: pmc: Add wake source interrupt for MGBE Sushil Singh
2023-04-03 12:37 ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCrIna6vM7T4m-wc@orome \
    --to=thierry.reding@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=linux-tegra@vger.kernel.org \
    --cc=sushilkumars@nvidia.com \
    --cc=treding@nvidia.com \
    --cc=vbhadram@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.