From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jiawen Wu <jiawenwu@trustnetic.com>,
netdev@vger.kernel.org, mengyuanlou@net-swift.com
Subject: Re: [PATCH net-next 6/6] net: txgbe: Support phylink MAC layer
Date: Mon, 3 Apr 2023 14:51:51 +0100 [thread overview]
Message-ID: <ZCrZ93yxnwWP8QeT@shell.armlinux.org.uk> (raw)
In-Reply-To: <ca3c82a9-4160-422a-a618-04ab04a19015@lunn.ch>
On Mon, Apr 03, 2023 at 03:22:03PM +0200, Andrew Lunn wrote:
> > +static void txgbe_mac_config(struct phylink_config *config, unsigned int mode,
> > + const struct phylink_link_state *state)
> > +{
> > +}
>
> That is very likely to be wrong. Lets see what Russell says.
I don't think that's a problem if the MAC is just something that
pumps data into the PCS at whatever rate the PCS wants.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2023-04-03 13:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 6:45 [PATCH net-next 0/6] TXGBE PHYLINK support Jiawen Wu
2023-04-03 6:45 ` [PATCH net-next 1/6] net: txgbe: Add software nodes to support phylink Jiawen Wu
2023-04-03 12:35 ` Andrew Lunn
2023-04-03 6:45 ` [PATCH net-next 2/6] net: txgbe: Implement I2C bus master driver Jiawen Wu
2023-04-03 12:52 ` Andrew Lunn
2023-04-04 2:47 ` Jiawen Wu
2023-04-04 14:18 ` Andrew Lunn
2023-04-06 6:59 ` Jiawen Wu
2023-04-07 2:03 ` Andrew Lunn
2023-04-03 6:45 ` [PATCH net-next 3/6] net: txgbe: Add SFP module identify Jiawen Wu
2023-04-03 12:58 ` Andrew Lunn
2023-04-03 6:45 ` [PATCH net-next 4/6] net: txgbe: Support GPIO to SFP socket Jiawen Wu
2023-04-03 13:16 ` Andrew Lunn
2023-04-03 6:45 ` [PATCH net-next 5/6] net: txgbe: Implement phylink pcs Jiawen Wu
2023-04-03 13:47 ` Russell King (Oracle)
2023-04-10 7:32 ` Jiawen Wu
2023-04-10 10:40 ` Russell King (Oracle)
2023-04-11 2:34 ` Jiawen Wu
2023-04-11 6:32 ` Jiawen Wu
2023-04-03 6:45 ` [PATCH net-next 6/6] net: txgbe: Support phylink MAC layer Jiawen Wu
2023-04-03 13:22 ` Andrew Lunn
2023-04-03 13:51 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCrZ93yxnwWP8QeT@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.