From: Peter Xu <peterx@redhat.com>
To: Alexander Graf <graf@amazon.com>
Cc: qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
"Daniel P . Berrange" <berrange@redhat.com>,
Eric Blake <eblake@redhat.com>,
Philippe Mathieu-Daude <philmd@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Ashish Kalra <ashish.kalra@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Elena Ufimtseva <elena.ufimtseva@oracle.com>,
Jagannathan Raman <jag.raman@oracle.com>,
John G Johnson <john.g.johnson@oracle.com>
Subject: Re: [PATCH v5] hostmem-file: add offset option
Date: Tue, 4 Apr 2023 10:36:25 -0400 [thread overview]
Message-ID: <ZCw16TyJf1iOS/1T@x1n> (raw)
In-Reply-To: <20230403221421.60877-1-graf@amazon.com>
On Mon, Apr 03, 2023 at 10:14:21PM +0000, Alexander Graf wrote:
> Add an option for hostmem-file to start the memory object at an offset
> into the target file. This is useful if multiple memory objects reside
> inside the same target file, such as a device node.
>
> In particular, it's useful to map guest memory directly into /dev/mem
> for experimentation.
>
> To make this work consistently, also fix up all places in QEMU that
> expect fd offsets to be 0.
>
> Signed-off-by: Alexander Graf <graf@amazon.com>
Acked-by: Peter Xu <peterx@redhat.com>
I also agree it'll be nicer to split the fix into separate patch, though.
The only affected part IIUC is multi-process QEMU since 6.0.0. Copying the
maintainers too so they'll be aware.
Corresponds to the tag:
Fixes: ed5d001916 ("multi-process: setup memory manager for remote device")
--
Peter Xu
next prev parent reply other threads:[~2023-04-04 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 22:14 [PATCH v5] hostmem-file: add offset option Alexander Graf
2023-04-04 6:48 ` Markus Armbruster
2023-04-04 14:36 ` Peter Xu [this message]
2023-04-05 13:58 ` David Hildenbrand
2023-04-11 11:46 ` Igor Mammedov
2023-04-20 17:22 ` David Hildenbrand
2023-05-03 13:40 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCw16TyJf1iOS/1T@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=ashish.kalra@amd.com \
--cc=berrange@redhat.com \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=elena.ufimtseva@oracle.com \
--cc=graf@amazon.com \
--cc=imammedo@redhat.com \
--cc=jag.raman@oracle.com \
--cc=john.g.johnson@oracle.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.