All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/2] getpgid01.c: Rewrite using new LTP API
Date: Wed, 19 Apr 2023 13:26:39 +0200	[thread overview]
Message-ID: <ZD/P71dlmvBbRhpb@yuki> (raw)
In-Reply-To: <20230413054952.14607-1-akumar@suse.de>

Hi!
> +		TST_EXP_POSITIVE(getpgid(1));

Actually I did remmmeber that we do have TST_EXP_PID() which should be
more fitting here, since getpgid() returns a PID. Do you agree with
changing these in the two tests before applying?

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2023-04-19 11:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13  5:49 [LTP] [PATCH v2 1/2] getpgid01.c: Rewrite using new LTP API Avinesh Kumar
2023-04-13  5:49 ` [LTP] [PATCH v2 2/2] getpgrp01: Convert to " Avinesh Kumar
2023-04-19 11:26 ` Cyril Hrubis [this message]
2023-04-19 12:22   ` [LTP] [PATCH v2 1/2] getpgid01.c: Rewrite using " Avinesh Kumar
2023-04-20  9:42     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZD/P71dlmvBbRhpb@yuki \
    --to=chrubis@suse.cz \
    --cc=akumar@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.