From: Simon Horman <simon.horman@corigine.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wireless: airo: remove ISA_DMA_API dependency
Date: Wed, 19 Apr 2023 15:34:29 +0200 [thread overview]
Message-ID: <ZD/t5VARDjrloYdG@corigine.com> (raw)
In-Reply-To: <20230417205131.1560074-1-arnd@kernel.org>
On Mon, Apr 17, 2023 at 10:51:24PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This driver does not actually use the ISA DMA API, it is purely
> PIO based, so remove the dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd,
I think that the subject prefix should probably be 'wifi: airo: '.
That nit aside, FWIIW, this looks good to me.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
> ---
> drivers/net/wireless/cisco/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/cisco/Kconfig b/drivers/net/wireless/cisco/Kconfig
> index 681bfc2d740a..b40ee25aca99 100644
> --- a/drivers/net/wireless/cisco/Kconfig
> +++ b/drivers/net/wireless/cisco/Kconfig
> @@ -14,7 +14,7 @@ if WLAN_VENDOR_CISCO
>
> config AIRO
> tristate "Cisco/Aironet 34X/35X/4500/4800 ISA and PCI cards"
> - depends on CFG80211 && ISA_DMA_API && (PCI || BROKEN)
> + depends on CFG80211 && (PCI || BROKEN)
> select WIRELESS_EXT
> select CRYPTO
> select CRYPTO_SKCIPHER
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-04-19 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 20:51 [PATCH] wireless: airo: remove ISA_DMA_API dependency Arnd Bergmann
2023-04-19 13:34 ` Simon Horman [this message]
2023-04-19 14:17 ` Kalle Valo
2023-04-20 12:38 ` wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD/t5VARDjrloYdG@corigine.com \
--to=simon.horman@corigine.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.