From: Mike Rapoport <rppt@linux.ibm.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-ia64@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] ia64: fix an addr to taddr in huge_pte_offset()
Date: Wed, 19 Apr 2023 09:29:55 +0000 [thread overview]
Message-ID: <ZD+0k0k4KzMzrmsT@linux.ibm.com> (raw)
In-Reply-To: <732eae88-3beb-246-2c72-281de786740@google.com>
On Sun, Apr 16, 2023 at 10:17:05PM -0700, Hugh Dickins wrote:
> I know nothing of ia64 htlbpage_to_page(), but guess that the p4d
> line should be using taddr rather than addr, like everywhere else.
>
> Fixes: c03ab9e32a2c ("ia64: add support for folded p4d page tables")
> Signed-off-by: Hugh Dickins <hughd@google.com
htlbpage_to_page() does weird things I don't understand, but I should have
used taddr indeed :)
Acked-by: Mike Rapoport (IBM) <rppt@kernel.org>
> ---
> Just something noticed when visiting recently in the source:
> thought we might fix it before ia64 is consigned to history;
> I'm unable to say anything about the user-visible effects!
>
> arch/ia64/mm/hugetlbpage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 6.3-rc7/arch/ia64/mm/hugetlbpage.c
> +++ linux/arch/ia64/mm/hugetlbpage.c
> @@ -58,7 +58,7 @@ huge_pte_offset (struct mm_struct *mm, unsigned long addr, unsigned long sz)
>
> pgd = pgd_offset(mm, taddr);
> if (pgd_present(*pgd)) {
> - p4d = p4d_offset(pgd, addr);
> + p4d = p4d_offset(pgd, taddr);
> if (p4d_present(*p4d)) {
> pud = pud_offset(p4d, taddr);
> if (pud_present(*pud)) {
--
Sincerely yours,
Mike.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@linux.ibm.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-ia64@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] ia64: fix an addr to taddr in huge_pte_offset()
Date: Wed, 19 Apr 2023 12:29:55 +0300 [thread overview]
Message-ID: <ZD+0k0k4KzMzrmsT@linux.ibm.com> (raw)
In-Reply-To: <732eae88-3beb-246-2c72-281de786740@google.com>
On Sun, Apr 16, 2023 at 10:17:05PM -0700, Hugh Dickins wrote:
> I know nothing of ia64 htlbpage_to_page(), but guess that the p4d
> line should be using taddr rather than addr, like everywhere else.
>
> Fixes: c03ab9e32a2c ("ia64: add support for folded p4d page tables")
> Signed-off-by: Hugh Dickins <hughd@google.com
htlbpage_to_page() does weird things I don't understand, but I should have
used taddr indeed :)
Acked-by: Mike Rapoport (IBM) <rppt@kernel.org>
> ---
> Just something noticed when visiting recently in the source:
> thought we might fix it before ia64 is consigned to history;
> I'm unable to say anything about the user-visible effects!
>
> arch/ia64/mm/hugetlbpage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 6.3-rc7/arch/ia64/mm/hugetlbpage.c
> +++ linux/arch/ia64/mm/hugetlbpage.c
> @@ -58,7 +58,7 @@ huge_pte_offset (struct mm_struct *mm, unsigned long addr, unsigned long sz)
>
> pgd = pgd_offset(mm, taddr);
> if (pgd_present(*pgd)) {
> - p4d = p4d_offset(pgd, addr);
> + p4d = p4d_offset(pgd, taddr);
> if (p4d_present(*p4d)) {
> pud = pud_offset(p4d, taddr);
> if (pud_present(*pud)) {
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2023-04-19 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 5:17 [PATCH] ia64: fix an addr to taddr in huge_pte_offset() Hugh Dickins
2023-04-17 5:17 ` Hugh Dickins
2023-04-18 20:29 ` Mike Kravetz
2023-04-18 20:29 ` Mike Kravetz
2023-04-19 9:29 ` Mike Rapoport [this message]
2023-04-19 9:29 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD+0k0k4KzMzrmsT@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=hughd@google.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.