From: Luke Koch <lu.ale.koch@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: replace rate macros
Date: Mon, 17 Apr 2023 10:25:41 +0200 [thread overview]
Message-ID: <ZD0ChREQnV8tKwS1@kernelhacking.kernelhacking.example.com> (raw)
In-Reply-To: <f44f44e4-25c0-4489-96e9-8ca63fa294d7@kili.mountain>
On Mon, Apr 17, 2023 at 11:04:04AM +0300, Dan Carpenter wrote:
> On Sat, Apr 15, 2023 at 04:10:44PM +0200, Luke Koch wrote:
> > + for (int i = 0; i < 8; i++) {
> > + if (count > i &&
> > + DOT11_RATE5_ISBASIC_GET(item->supprates[i])) {
> > + req->basicrate[i] .data = item->supprates[i];
> ^
> Could you remove these spaces before the .data and .status? Otherwise
> it looks good to me.
Sure, the spaces must have been leftovers from the token pasting and I
unfortunately overlooked them. Thanks for reviewing!
Best regards,
Luke Koch
prev parent reply other threads:[~2023-04-17 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 14:10 [PATCH v2] staging: wlan-ng: replace rate macros Luke Koch
2023-04-17 8:04 ` Dan Carpenter
2023-04-17 8:25 ` Luke Koch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD0ChREQnV8tKwS1@kernelhacking.kernelhacking.example.com \
--to=lu.ale.koch@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.