From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joy Chakraborty <joychakr@google.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
manugautam@google.com, rohitner@google.com
Subject: Re: [PATCH v7 4/5] spi: dw: Add DMA address widths capability check
Date: Tue, 18 Apr 2023 10:38:51 +0300 [thread overview]
Message-ID: <ZD5JC7BdN1usn6Kd@smile.fi.intel.com> (raw)
In-Reply-To: <20230418052902.1336866-5-joychakr@google.com>
On Tue, Apr 18, 2023 at 05:29:01AM +0000, Joy Chakraborty wrote:
> Store address width capabilities of DMA controller during init and check
> the same per transfer to make sure the bits/word requirement can be met.
>
> Current DW DMA driver requires both tx and rx channel to be configured
> and functional hence a subset of both tx and rx channel address width
> capability is checked with the width requirement(n_bytes) for a
> transfer.
...
> + /*
> + * Assuming both channels belong to the same DMA controller hence the
> + * address width capabilities most likely would be the same.
> + */
I had a small comment on this In v6 thread.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-04-18 7:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 5:28 [PATCH v7 0/5] spi: dw: DW SPI DMA Driver updates Joy Chakraborty
2023-04-18 5:28 ` [PATCH v7 1/5] spi: dw: Add 32 bpw support to SPI DW DMA driver Joy Chakraborty
2023-04-18 5:28 ` [PATCH v7 2/5] spi: dw: Move dw_spi_can_dma() Joy Chakraborty
2023-04-18 5:29 ` [PATCH v7 3/5] spi: dw: Add DMA directional capability check Joy Chakraborty
2023-04-18 5:29 ` [PATCH v7 4/5] spi: dw: Add DMA address widths " Joy Chakraborty
2023-04-18 7:38 ` Andy Shevchenko [this message]
2023-04-19 5:48 ` Joy Chakraborty
2023-04-19 11:49 ` Andy Shevchenko
2023-04-19 12:48 ` Joy Chakraborty
2023-04-19 14:55 ` Joy Chakraborty
2023-04-19 17:35 ` Andy Shevchenko
2023-04-19 21:03 ` Joy Chakraborty
2023-04-18 5:29 ` [PATCH v7 5/5] spi: dw: Round of n_bytes to power of 2 Joy Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD5JC7BdN1usn6Kd@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=joychakr@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=manugautam@google.com \
--cc=rohitner@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.