From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECA961FD9 for ; Wed, 19 Apr 2023 05:45:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA0E0C433EF; Wed, 19 Apr 2023 05:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681883120; bh=rHIVwcWlnAi6I7EkL3r3k1a15viUoZ98G0Ds8/Yst4M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H/BGdcSYEk2ZQ32pQ/0W1uRry9lv83+rgnE4uGpjyOtQqRFDNUni+12kavXJZm2No NRSeFPNyOaiol6RH221aAeH0iJ7QLpGF282uUoj1w6ZESa0iGmg61OKWt37WA6h2/P 3uAY8LG6/vzl6VbVkSGZTHmZkTIsOffKc3D4w/e9jysM530tYnCBj/EMyo4p1rc2Kx eCpBKX7SsQ+yDJE3ON1iwcBGWo30qaD7n1lfrZPW85hzpGUH7meWLVGjQH2KdlOdF3 /UiVSEa2frokvmHdbWV+y0PTiQ89/vjtpefaqFOl+dxdb7BIrFF4QqPynZlk3oHO0u iP8KnCri24PZA== Date: Wed, 19 Apr 2023 07:45:16 +0200 From: Simon Horman To: Nick Desaulniers Cc: Nishanth Menon , Santosh Shilimkar , Nathan Chancellor , Tom Rix , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [PATCH] soc: ti: pruss: Avoid cast to incompatible function type Message-ID: References: <20230418-pruss-clk-cb-v1-1-549a7e7febe4@kernel.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Apr 18, 2023 at 11:44:28AM -0700, Nick Desaulniers wrote: > On Tue, Apr 18, 2023 at 4:41 AM Simon Horman wrote: > > > > Rather than casting clk_unregister_mux to an incompatible function > > type provide a trivial wrapper with the correct signature for the > > use-case. > > > > Reported by clang-16 with W=1: > > > > drivers/soc/ti/pruss.c:158:38: error: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict] > > ret = devm_add_action_or_reset(dev, (void(*)(void *))clk_unregister_mux, > > > > No functional change intended. > > Compile tested only. > > Thanks for the patch! > Reviewed-by: Nick Desaulniers > > Here's some more suspects to look at, if you have cycles: > drivers/base/devres.c:734:int __devm_add_action(struct device *dev, > void (*action)(void *), void *data, const char *name) > drivers/i2c/busses/i2c-mchp-pci1xxxx.c:1159: ret = > devm_add_action(dev, (void (*)(void *))pci1xxxx_i2c_shutdown, i2c); > drivers/soc/ti/pruss.c:96: ret = devm_add_action_or_reset(dev, > (void(*)(void *))clk_unregister_mux, > drivers/mmc/host/meson-mx-sdhc-mmc.c:791: ret = > devm_add_action_or_reset(dev, (void(*)(void *))mmc_free_host, > drivers/pci/controller/pcie-microchip-host.c:866: > devm_add_action_or_reset(dev, (void (*) (void > *))clk_disable_unprepare, Thanks, I will take a look as a background task. Let me know if there is any urgency on your side. ... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 275BBC77B73 for ; Wed, 19 Apr 2023 05:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pOvT5+I/i1zyKAN2u2lDFSkHdVJlGu5GooZ3vrehwHg=; b=0FLRjuQl8CAmMo 5MaYtUvA/IwDYPOKieScoxxJ+WBQ/Vttlzy8WtOlhuzf5UfisF7bjQ1fVE9QJY/PllOaCaxLM9Uxf dfAKwnHW5DT4Upannsy0mHznEBVq2qE8mFFJ7hATKWKfJN4Ryw7FJVN1UXOGZyty6oKRoIYW0XzjE wXKYchjup4nRd6xwwh5JgN9SHS3HX3ZmJCclfG720LsoJw/IIvDiyWnIPQj9GIbE0seDY6V2/teAN fW+dlpxhfIj10VNk97KpTBqPDcFqTR3U3JdFBT9M7RCdUAdz6qQOxiKFjcjV3+0SC4M9bxw3yXorS CRF27ydLI+XokVNKiDzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pp0dA-00482g-1z; Wed, 19 Apr 2023 05:45:24 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pp0d7-004828-2K for linux-arm-kernel@lists.infradead.org; Wed, 19 Apr 2023 05:45:22 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E8EA60FB5; Wed, 19 Apr 2023 05:45:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA0E0C433EF; Wed, 19 Apr 2023 05:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681883120; bh=rHIVwcWlnAi6I7EkL3r3k1a15viUoZ98G0Ds8/Yst4M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H/BGdcSYEk2ZQ32pQ/0W1uRry9lv83+rgnE4uGpjyOtQqRFDNUni+12kavXJZm2No NRSeFPNyOaiol6RH221aAeH0iJ7QLpGF282uUoj1w6ZESa0iGmg61OKWt37WA6h2/P 3uAY8LG6/vzl6VbVkSGZTHmZkTIsOffKc3D4w/e9jysM530tYnCBj/EMyo4p1rc2Kx eCpBKX7SsQ+yDJE3ON1iwcBGWo30qaD7n1lfrZPW85hzpGUH7meWLVGjQH2KdlOdF3 /UiVSEa2frokvmHdbWV+y0PTiQ89/vjtpefaqFOl+dxdb7BIrFF4QqPynZlk3oHO0u iP8KnCri24PZA== Date: Wed, 19 Apr 2023 07:45:16 +0200 From: Simon Horman To: Nick Desaulniers Cc: Nishanth Menon , Santosh Shilimkar , Nathan Chancellor , Tom Rix , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [PATCH] soc: ti: pruss: Avoid cast to incompatible function type Message-ID: References: <20230418-pruss-clk-cb-v1-1-549a7e7febe4@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230418_224521_799622_DAF4EE68 X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMTgsIDIwMjMgYXQgMTE6NDQ6MjhBTSAtMDcwMCwgTmljayBEZXNhdWxuaWVy cyB3cm90ZToKPiBPbiBUdWUsIEFwciAxOCwgMjAyMyBhdCA0OjQx4oCvQU0gU2ltb24gSG9ybWFu IDxob3Jtc0BrZXJuZWwub3JnPiB3cm90ZToKPiA+Cj4gPiBSYXRoZXIgdGhhbiBjYXN0aW5nIGNs a191bnJlZ2lzdGVyX211eCB0byBhbiBpbmNvbXBhdGlibGUgZnVuY3Rpb24KPiA+IHR5cGUgcHJv dmlkZSBhIHRyaXZpYWwgd3JhcHBlciB3aXRoIHRoZSBjb3JyZWN0IHNpZ25hdHVyZSBmb3IgdGhl Cj4gPiB1c2UtY2FzZS4KPiA+Cj4gPiBSZXBvcnRlZCBieSBjbGFuZy0xNiB3aXRoIFc9MToKPiA+ Cj4gPiAgZHJpdmVycy9zb2MvdGkvcHJ1c3MuYzoxNTg6Mzg6IGVycm9yOiBjYXN0IGZyb20gJ3Zv aWQgKCopKHN0cnVjdCBjbGsgKiknIHRvICd2b2lkICgqKSh2b2lkICopJyBjb252ZXJ0cyB0byBp bmNvbXBhdGlibGUgZnVuY3Rpb24gdHlwZSBbLVdlcnJvciwtV2Nhc3QtZnVuY3Rpb24tdHlwZS1z dHJpY3RdCj4gPiAgICAgICAgICByZXQgPSBkZXZtX2FkZF9hY3Rpb25fb3JfcmVzZXQoZGV2LCAo dm9pZCgqKSh2b2lkICopKWNsa191bnJlZ2lzdGVyX211eCwKPiA+Cj4gPiBObyBmdW5jdGlvbmFs IGNoYW5nZSBpbnRlbmRlZC4KPiA+IENvbXBpbGUgdGVzdGVkIG9ubHkuCj4gCj4gVGhhbmtzIGZv ciB0aGUgcGF0Y2ghCj4gUmV2aWV3ZWQtYnk6IE5pY2sgRGVzYXVsbmllcnMgPG5kZXNhdWxuaWVy c0Bnb29nbGUuY29tPgo+IAo+IEhlcmUncyBzb21lIG1vcmUgc3VzcGVjdHMgdG8gbG9vayBhdCwg aWYgeW91IGhhdmUgY3ljbGVzOgo+IGRyaXZlcnMvYmFzZS9kZXZyZXMuYzo3MzQ6aW50IF9fZGV2 bV9hZGRfYWN0aW9uKHN0cnVjdCBkZXZpY2UgKmRldiwKPiB2b2lkICgqYWN0aW9uKSh2b2lkICop LCB2b2lkICpkYXRhLCBjb25zdCBjaGFyICpuYW1lKQo+IGRyaXZlcnMvaTJjL2J1c3Nlcy9pMmMt bWNocC1wY2kxeHh4eC5jOjExNTk6IHJldCA9Cj4gZGV2bV9hZGRfYWN0aW9uKGRldiwgKHZvaWQg KCopKHZvaWQgKikpcGNpMXh4eHhfaTJjX3NodXRkb3duLCBpMmMpOwo+IGRyaXZlcnMvc29jL3Rp L3BydXNzLmM6OTY6IHJldCA9IGRldm1fYWRkX2FjdGlvbl9vcl9yZXNldChkZXYsCj4gKHZvaWQo Kikodm9pZCAqKSljbGtfdW5yZWdpc3Rlcl9tdXgsCj4gZHJpdmVycy9tbWMvaG9zdC9tZXNvbi1t eC1zZGhjLW1tYy5jOjc5MTogcmV0ID0KPiBkZXZtX2FkZF9hY3Rpb25fb3JfcmVzZXQoZGV2LCAo dm9pZCgqKSh2b2lkICopKW1tY19mcmVlX2hvc3QsCj4gZHJpdmVycy9wY2kvY29udHJvbGxlci9w Y2llLW1pY3JvY2hpcC1ob3N0LmM6ODY2Ogo+IGRldm1fYWRkX2FjdGlvbl9vcl9yZXNldChkZXYs ICh2b2lkICgqKSAodm9pZAo+ICopKWNsa19kaXNhYmxlX3VucHJlcGFyZSwKClRoYW5rcywgSSB3 aWxsIHRha2UgYSBsb29rIGFzIGEgYmFja2dyb3VuZCB0YXNrLgpMZXQgbWUga25vdyBpZiB0aGVy ZSBpcyBhbnkgdXJnZW5jeSBvbiB5b3VyIHNpZGUuCgouLi4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK