From: Sean Christopherson <seanjc@google.com>
To: Aaron Lewis <aaronlewis@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, jmattson@google.com,
like.xu.linux@gmail.com
Subject: Re: [PATCH v3 4/5] KVM: selftests: Fixup test asserts
Date: Fri, 7 Apr 2023 11:53:02 -0700 [thread overview]
Message-ID: <ZDBmjt0+nFkZkoG6@google.com> (raw)
In-Reply-To: <20230307141400.1486314-5-aaronlewis@google.com>
Same shortlog problem.
On Tue, Mar 07, 2023, Aaron Lewis wrote:
> Fix up both ASSERT_PMC_COUNTING and ASSERT_PMC_NOT_COUNTING in the
> pmu_event_filter_test by adding additional context in the assert
> message.
I 100% agree that the asserts are flawed, but in the context of changelogs, "fix"
almost always implies something is broken. In this case, what is being asserted
is completely ok, it's only the messages that are bad.
Easiest thing is to just describe the change and explain why it's desirable, and
dodge the question of whether or not this should be considered a fix.
Provide the actual vs. expected count in the PMU event filter test's
asserts instead of relying on pr_info() to provide the context, e.g. so
that all information needed to triage a failure is readily available even
if the environment in which the test is run captures only the assert
itself.
next prev parent reply other threads:[~2023-04-07 18:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 14:13 [PATCH v3 0/5] Fix "Instructions Retired" from incorrectly counting Aaron Lewis
2023-03-07 14:13 ` [PATCH v3 1/5] KVM: x86/pmu: Prevent the PMU from counting disallowed events Aaron Lewis
2023-03-07 15:19 ` Like Xu
2023-03-07 15:52 ` Aaron Lewis
2023-03-07 16:01 ` Sean Christopherson
2023-03-08 2:45 ` Like Xu
2023-03-08 19:46 ` Sean Christopherson
2023-03-07 14:13 ` [PATCH v3 2/5] KVM: selftests: Add a common helper to the guest Aaron Lewis
2023-04-07 18:43 ` Sean Christopherson
2023-03-07 14:13 ` [PATCH v3 3/5] KVM: selftests: Add helpers for PMC asserts Aaron Lewis
2023-04-07 18:47 ` Sean Christopherson
2023-03-07 14:13 ` [PATCH v3 4/5] KVM: selftests: Fixup test asserts Aaron Lewis
2023-04-07 18:53 ` Sean Christopherson [this message]
2023-03-07 14:14 ` [PATCH v3 5/5] KVM: selftests: Test the PMU event "Instructions retired" Aaron Lewis
2023-04-07 20:17 ` Sean Christopherson
2023-04-07 9:06 ` [PATCH v3 0/5] Fix "Instructions Retired" from incorrectly counting Like Xu
2023-04-07 21:30 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDBmjt0+nFkZkoG6@google.com \
--to=seanjc@google.com \
--cc=aaronlewis@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.