All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Welling <mwelling@ieee.org>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: iio: dac: mcp4922: add vdd-supply property
Date: Sun, 9 Apr 2023 15:52:46 -0500	[thread overview]
Message-ID: <ZDMlnj3+CpU4BPdt@deathstar> (raw)
In-Reply-To: <20230405140114.99011-2-frattaroli.nicolas@gmail.com>

On Wed, Apr 05, 2023 at 04:01:11PM +0200, Nicolas Frattaroli wrote:
> These chips have a vdd supply input, which should be modelled in
> the bindings as well. Vref is only the voltage reference supply for
> the string DAC.
> 
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>

Acked-by: Michael Welling <mwelling@ieee.org>

> ---
>  .../devicetree/bindings/iio/dac/microchip,mcp4922.yaml        | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml
> index 19374401e509..a3e80e90eeca 100644
> --- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4922.yaml
> @@ -21,11 +21,14 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  vdd-supply: true
> +
>    vref-supply: true
>  
>  required:
>    - compatible
>    - reg
> +  - vdd-supply
>    - vref-supply
>  
>  allOf:
> @@ -42,6 +45,7 @@ examples:
>          dac@0 {
>              compatible = "microchip,mcp4912";
>              reg = <0>;
> +            vdd-supply = <&dac_reg>;
>              vref-supply = <&dac_vref>;
>          };
>      };
> -- 
> 2.40.0
> 

  reply	other threads:[~2023-04-09 20:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05 14:01 [PATCH 0/4] Add MCP48XX bindings and driver support Nicolas Frattaroli
2023-04-05 14:01 ` [PATCH 1/4] dt-bindings: iio: dac: mcp4922: add vdd-supply property Nicolas Frattaroli
2023-04-09 20:52   ` Michael Welling [this message]
2023-04-05 14:01 ` [PATCH 2/4] iio: dac: mcp4922: get and enable vdd regulator Nicolas Frattaroli
2023-04-05 14:21   ` Lars-Peter Clausen
2023-04-07 17:46     ` Jonathan Cameron
2023-04-07 17:44   ` Jonathan Cameron
2023-04-05 14:01 ` [PATCH 3/4] dt-bindings: iio: dac: add mcp4822 Nicolas Frattaroli
2023-04-05 14:10   ` Krzysztof Kozlowski
2023-04-05 14:17     ` Nicolas Frattaroli
2023-04-06 18:58       ` Krzysztof Kozlowski
2023-04-05 14:01 ` [PATCH 4/4] iio: dac: mcp4922: add support for mcp48xx series chips Nicolas Frattaroli
2023-04-05 14:18   ` Lars-Peter Clausen
2023-04-07 17:35     ` Jonathan Cameron
2023-04-07 17:40   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZDMlnj3+CpU4BPdt@deathstar \
    --to=mwelling@ieee.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frattaroli.nicolas@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.