From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE2A6C76196 for ; Mon, 10 Apr 2023 17:57:43 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1plvlr-0003q5-GK; Mon, 10 Apr 2023 17:57:41 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1plvlk-0003pz-Lr for linux-f2fs-devel@lists.sourceforge.net; Mon, 10 Apr 2023 17:57:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+rJ0HzSlsN2qDLRasn/SNIDGChbSYp6qeUhbUCXs+Jw=; b=e23EAz6h6n7N6U7mP23rDhUh3H wMqIJmo0UbenZqj6CQRQna69GtO0Zg5u6xXTHL3EeL3113/3WnY20yPqV/XiK4/PDKyQLwC9MN7mL OSQidjiBjtQqpR0zYHW6AWVn4y5FfYFx5RUaogRsO4cPM9UjfCLiwEukO8ulQMQhXALw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+rJ0HzSlsN2qDLRasn/SNIDGChbSYp6qeUhbUCXs+Jw=; b=jCTGHq8Jt0yPUmG8nqiSmY+thW MYCW41hhNe0xPXYMEQqqahSvRrGwreVW2cdgosTH/TdmvIaC7Paf8SwgYdAxpfYC+zGSIQSzSjxGN Bl5pKlZFtSABhP+tMXFIG2H/I+Mpo1PF6Ttb04SO1xp6IAf+WXiUz2EP9VF1ouKclJG4=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1plvlk-0034KC-NT for linux-f2fs-devel@lists.sourceforge.net; Mon, 10 Apr 2023 17:57:33 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 58DC261B5D for ; Mon, 10 Apr 2023 17:57:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5809C433EF; Mon, 10 Apr 2023 17:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681149446; bh=pRusvesWgcLH3mFrSqqGUneripwEMIKM/L3+hxDKUDg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WgozEOTWyqyrh7PZvvmUHT6JNgN6L2x+FM/GC7Tt98GLdJyIHpNxv6qJhGKxrOm5E b4oBnhpcPIrh7nABA8ak+VDCrPC1Y1C6OYWgMve7ft8m4ON32x3Ug5jHLd3eyfOrR4 ccDfKbXIzyl++l4GsLQsKJZrOlrUtdWu4OjPOoH79ctW3/mO6EoiYphGdIkhki9eon 6CQPB/ncYPUBNahNwftZo+FUccwt9pT8pFADkOvSUfoFuvGPHY2c9tSI1tXdynyZw0 eocbLR6XFTrqtVhb33yU7m7IEw2sD4sfdBxrYkCN1tuFVDlbovvSEbsJHvTNoOiJF/ c6z7UKi7x9P/A== Date: Mon, 10 Apr 2023 10:57:24 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20230405144359.930253-1-chao@kernel.org> <224e8756-7c63-fd53-a0f3-f3e2a7b4c13f@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <224e8756-7c63-fd53-a0f3-f3e2a7b4c13f@kernel.org> X-Headers-End: 1plvlk-0034KC-NT Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to tag FIEMAP_EXTENT_DELALLOC in fiemap() for delay allocated extent X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMDQvMDgsIENoYW8gWXUgd3JvdGU6Cj4gT24gMjAyMy80LzggNDo1OSwgSmFlZ2V1ayBLaW0g d3JvdGU6Cj4gPiBUaGlzIGJyZWFrcyBnZW5lcmljLzAwOT8KPiAKPiBJIGd1ZXNzIGl0IGlzIGFz IGV4cGVjdGVkPwo+IAo+IFBsZWFzZSBjaGVjayBkZXNjcmlwdGlvbiBvZiBmaWVtYXAgaW9jdGwg bWFudWFsIGZyb20gWzFdOgo+IAo+IEZJRU1BUF9FWFRFTlRfVU5LTk9XTgo+IFRoZSBsb2NhdGlv biBvZiB0aGlzIGV4dGVudCBpcyBjdXJyZW50bHkgdW5rbm93bi4gVGhpcyBtYXkKPiBpbmRpY2F0 ZSB0aGUgZGF0YSBpcyBzdG9yZWQgb24gYW4gaW5hY2Nlc3NpYmxlIHZvbHVtZSBvciB0aGF0Cj4g bm8gc3RvcmFnZSBoYXMgYmVlbiBhbGxvY2F0ZWQgZm9yIHRoZSBmaWxlIHlldC4KPiAKPiBGSUVN QVBfRVhURU5UX0RFTEFMTE9DCj4gVGhpcyB3aWxsIGFsc28gc2V0IEZJRU1BUF9FWFRFTlRfVU5L Tk9XTi4KPiAKPiBEZWxheWVkIGFsbG9jYXRpb24gLSB3aGlsZSB0aGVyZSBpcyBkYXRhIGZvciB0 aGlzIGV4dGVudCwgaXRzCj4gcGh5c2ljYWwgbG9jYXRpb24gaGFzIG5vdCBiZWVuIGFsbG9jYXRl ZCB5ZXQuCj4gCj4gRklFTUFQX0VYVEVOVF9VTldSSVRURU4KPiBVbndyaXR0ZW4gZXh0ZW50IC0g dGhlIGV4dGVudCBpcyBhbGxvY2F0ZWQgYnV0IGl0cyBkYXRhIGhhcyBub3QKPiBiZWVuIGluaXRp YWxpemVkLiBUaGlzIGluZGljYXRlcyB0aGUgZXh0ZW504oCZcyBkYXRhIHdpbGwgYmUgYWxsCj4g emVybyBpZiByZWFkIHRocm91Z2ggdGhlIGZpbGVzeXN0ZW0gYnV0IHRoZSBjb250ZW50cyBhcmUg dW5kZWZpbmVkCj4gaWYgcmVhZCBkaXJlY3RseSBmcm9tIHRoZSBkZXZpY2UuCj4gCj4gWzFdIGh0 dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9jL2h0bWwvbGF0ZXN0L2ZpbGVzeXN0ZW1zL2ZpZW1hcC5o dG1sCj4gCj4gQWNjb3JkaW5nIHRvIGl0cyBkZXNjcmlwdGlvbiwgZjJmcyBvbmx5IHN1cHBvcnQK PiBGSUVNQVBfRVhURU5UX3tVTktOT1dOLCBERUxBTExPQ30sIGJ1dCBub3Qgc3VwcG9ydAo+IEZJ RU1BUF9FWFRFTlRfVU5XUklUVEVOLgoKTm8sIEkgZG9uJ3QgdGhpbmsgc28uCgo+IAo+IFNvIDAw OSwgMDkyLCAwOTQgLi4gd2hpY2ggZXhwZWN0cyB1bndyaXR0ZW4gc3RhdHVzIGZyb20gZXh0ZW50 IHdpbGwKPiBmYWlsLgo+IAo+IEhvdyBhYm91dCBkaXNhYmxpbmcgdGhvc2UgdGVzdGNhc2U/Cj4g Cj4gVGhhbmtzLAo+IAo+ID4gCj4gPiBPbiAwNC8wNSwgQ2hhbyBZdSB3cm90ZToKPiA+ID4geGZz dGVzdCBnZW5lcmljLzYxNCBmYWlscyB0byBydW4gZHVlIGJlbG93IHJlYXNvbjoKPiA+ID4gCj4g PiA+IGdlbmVyaWMvNjE0IDFzIC4uLiBbbm90IHJ1bl0gdGVzdCByZXF1aXJlcyBkZWxheWVkIGFs bG9jYXRpb24gYnVmZmVyZWQgd3JpdGVzCj4gPiA+IAo+ID4gPiBUaGUgcm9vdCBjYXVzZSBpcyBm MmZzIHRhZ3Mgd3JvbmcgZmllbWFwIGZsYWcgZm9yIGRlbGF5IGFsbG9jYXRlZAo+ID4gPiBleHRl bnQuCj4gPiA+IAo+ID4gPiBRdW90ZWQgZnJvbSBmaWVtYXAuaDoKPiA+ID4gRklFTUFQX0VYVEVO VF9VTktOT1dOCQkweDAwMDAwMDAyIC8qIERhdGEgbG9jYXRpb24gdW5rbm93bi4gKi8KPiA+ID4g RklFTUFQX0VYVEVOVF9ERUxBTExPQwkJMHgwMDAwMDAwNCAvKiBMb2NhdGlvbiBzdGlsbCBwZW5k aW5nLgo+ID4gPiAJCQkJCQkgICAgKiBTZXRzIEVYVEVOVF9VTktOT1dOLiAqLwo+ID4gPiBGSUVN QVBfRVhURU5UX1VOV1JJVFRFTgkJMHgwMDAwMDgwMCAvKiBTcGFjZSBhbGxvY2F0ZWQsIGJ1dAo+ ID4gPiAJCQkJCQkgICAgKiBubyBkYXRhIChpLmUuIHplcm8pLiAqLwo+ID4gPiAKPiA+ID4gRklF TUFQX0VYVEVOVF9VTldSSVRURU4gbWVhbnMgYmxvY2sgYWRkcmVzcyBpcyBwcmVhbGxvY2F0ZWQs IGJ1dCB3L28KPiA+ID4gYmVlbiB3cml0dGVuIGFueSBkYXRhLCB3aGljaCBzdGF0dXMgZjJmcyBp cyBub3Qgc3VwcG9ydGVkIG5vdywgZm9yIGFsbAo+ID4gPiBORVdfQUREUiBibG9jayBhZGRyZXNz ZXMsIGl0IG1lYW5zIGRlbGF5IGFsbG9jYXRlZCBibG9ja3MsIHNvIGxldCdzCj4gPiA+IHRhZyBG SUVNQVBfRVhURU5UX0RFTEFMTE9DIGluc3RlYWQuCj4gPiA+IAo+ID4gPiBUZXN0Y2FzZToKPiA+ ID4geGZzX2lvIC1mIC1jICdwd3JpdGUgMCA2NGsnIC9tbnQvZjJmcy9maWxlOwo+ID4gPiBmaWxl ZnJhZyAtdiAvbW50L2YyZnMvZmlsZQo+ID4gPiAKPiA+ID4gT3V0cHV0Ogo+ID4gPiAtIEJlZm9y ZQo+ID4gPiBGaWxlc3lzdGVtIHR5cGUgaXM6IGYyZjUyMDEwCj4gPiA+IEZpemUgb2YgL21udC9m MmZzL2ZpbGUgaXMgNjU1MzYgKDE2IGJsb2NrcyBvZiA0MDk2IGJ5dGVzKQo+ID4gPiAgIGV4dDog ICAgIGxvZ2ljYWxfb2Zmc2V0OiAgICAgICAgcGh5c2ljYWxfb2Zmc2V0OiBsZW5ndGg6ICAgZXhw ZWN0ZWQ6IGZsYWdzOgo+ID4gPiAgICAgMDogICAgICAgIDAuLiAgICAgIDE1OiAgICAgICAgICAw Li4gICAgICAgIDE1OiAgICAgMTY6ICAgICAgICAgICAgIGxhc3QsdW53cml0dGVuLG1lcmdlZCxl b2YKPiA+ID4gL21udC9mMmZzL2ZpbGU6IDEgZXh0ZW50IGZvdW5kCj4gPiA+IAo+ID4gPiBBZnRl cjoKPiA+ID4gRmlsZXN5c3RlbSB0eXBlIGlzOiBmMmY1MjAxMAo+ID4gPiBGaWxlIHNpemUgb2Yg L21udC9mMmZzL2ZpbGUgaXMgNjU1MzYgKDE2IGJsb2NrcyBvZiA0MDk2IGJ5dGVzKQo+ID4gPiAg IGV4dDogICAgIGxvZ2ljYWxfb2Zmc2V0OiAgICAgICAgcGh5c2ljYWxfb2Zmc2V0OiBsZW5ndGg6 ICAgZXhwZWN0ZWQ6IGZsYWdzOgo+ID4gPiAgICAgMDogICAgICAgIDAuLiAgICAgIDE1OiAgICAg ICAgICAwLi4gICAgICAgICAwOiAgICAgIDA6ICAgICAgICAgICAgIGxhc3QsdW5rbm93bl9sb2Ms ZGVsYWxsb2MsZW9mCj4gPiA+IC9tbnQvZjJmcy9maWxlOiAxIGV4dGVudCBmb3VuZAo+ID4gPiAK PiA+ID4gRml4ZXM6IDdmNjNlYjc3YWY3YiAoImYyZnM6IHJlcG9ydCB1bndyaXR0ZW4gYXJlYSBp biBmMmZzX2ZpZW1hcCIpCj4gPiA+IFNpZ25lZC1vZmYtYnk6IENoYW8gWXUgPGNoYW9Aa2VybmVs Lm9yZz4KPiA+ID4gLS0tCj4gPiA+ICAgZnMvZjJmcy9kYXRhLmMgfCA3ICsrKysrLS0KPiA+ID4g ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gPiAK PiA+ID4gZGlmZiAtLWdpdCBhL2ZzL2YyZnMvZGF0YS5jIGIvZnMvZjJmcy9kYXRhLmMKPiA+ID4g aW5kZXggMzU5ZGU2NTA3NzJlLi4zYWZjOTc2NDc0M2UgMTAwNjQ0Cj4gPiA+IC0tLSBhL2ZzL2Yy ZnMvZGF0YS5jCj4gPiA+ICsrKyBiL2ZzL2YyZnMvZGF0YS5jCj4gPiA+IEBAIC0xOTk1LDcgKzE5 OTUsMTAgQEAgaW50IGYyZnNfZmllbWFwKHN0cnVjdCBpbm9kZSAqaW5vZGUsIHN0cnVjdCBmaWVt YXBfZXh0ZW50X2luZm8gKmZpZWluZm8sCj4gPiA+ICAgCX0KPiA+ID4gICAJaWYgKHNpemUpIHsK PiA+ID4gLQkJZmxhZ3MgfD0gRklFTUFQX0VYVEVOVF9NRVJHRUQ7Cj4gPiA+ICsJCWlmIChmbGFn cyAmIEZJRU1BUF9FWFRFTlRfREVMQUxMT0MpCj4gPiA+ICsJCQlwaHlzID0gMDsKPiA+ID4gKwkJ ZWxzZQo+ID4gPiArCQkJZmxhZ3MgfD0gRklFTUFQX0VYVEVOVF9NRVJHRUQ7Cj4gPiA+ICAgCQlp ZiAoSVNfRU5DUllQVEVEKGlub2RlKSkKPiA+ID4gICAJCQlmbGFncyB8PSBGSUVNQVBfRVhURU5U X0RBVEFfRU5DUllQVEVEOwo+ID4gPiBAQCAtMjAzNSw3ICsyMDM4LDcgQEAgaW50IGYyZnNfZmll bWFwKHN0cnVjdCBpbm9kZSAqaW5vZGUsIHN0cnVjdCBmaWVtYXBfZXh0ZW50X2luZm8gKmZpZWlu Zm8sCj4gPiA+ICAgCQkJCXNpemUgKz0gYmxrc190b19ieXRlcyhpbm9kZSwgMSk7Cj4gPiA+ICAg CQkJfQo+ID4gPiAgIAkJfSBlbHNlIGlmIChtYXAubV9mbGFncyAmIEYyRlNfTUFQX0RFTEFMTE9D KSB7Cj4gPiA+IC0JCQlmbGFncyA9IEZJRU1BUF9FWFRFTlRfVU5XUklUVEVOOwo+ID4gPiArCQkJ ZmxhZ3MgPSBGSUVNQVBfRVhURU5UX0RFTEFMTE9DOwo+ID4gPiAgIAkJfQo+ID4gPiAgIAkJc3Rh cnRfYmxrICs9IGJ5dGVzX3RvX2Jsa3MoaW5vZGUsIHNpemUpOwo+ID4gPiAtLSAKPiA+ID4gMi4z Ni4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGlu dXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKTGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vm b3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGlu dXgtZjJmcy1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CCC9C76196 for ; Mon, 10 Apr 2023 17:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230270AbjDJR5a (ORCPT ); Mon, 10 Apr 2023 13:57:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230042AbjDJR52 (ORCPT ); Mon, 10 Apr 2023 13:57:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF32EE47 for ; Mon, 10 Apr 2023 10:57:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6801C61E27 for ; Mon, 10 Apr 2023 17:57:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5809C433EF; Mon, 10 Apr 2023 17:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681149446; bh=pRusvesWgcLH3mFrSqqGUneripwEMIKM/L3+hxDKUDg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WgozEOTWyqyrh7PZvvmUHT6JNgN6L2x+FM/GC7Tt98GLdJyIHpNxv6qJhGKxrOm5E b4oBnhpcPIrh7nABA8ak+VDCrPC1Y1C6OYWgMve7ft8m4ON32x3Ug5jHLd3eyfOrR4 ccDfKbXIzyl++l4GsLQsKJZrOlrUtdWu4OjPOoH79ctW3/mO6EoiYphGdIkhki9eon 6CQPB/ncYPUBNahNwftZo+FUccwt9pT8pFADkOvSUfoFuvGPHY2c9tSI1tXdynyZw0 eocbLR6XFTrqtVhb33yU7m7IEw2sD4sfdBxrYkCN1tuFVDlbovvSEbsJHvTNoOiJF/ c6z7UKi7x9P/A== Date: Mon, 10 Apr 2023 10:57:24 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix to tag FIEMAP_EXTENT_DELALLOC in fiemap() for delay allocated extent Message-ID: References: <20230405144359.930253-1-chao@kernel.org> <224e8756-7c63-fd53-a0f3-f3e2a7b4c13f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <224e8756-7c63-fd53-a0f3-f3e2a7b4c13f@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08, Chao Yu wrote: > On 2023/4/8 4:59, Jaegeuk Kim wrote: > > This breaks generic/009? > > I guess it is as expected? > > Please check description of fiemap ioctl manual from [1]: > > FIEMAP_EXTENT_UNKNOWN > The location of this extent is currently unknown. This may > indicate the data is stored on an inaccessible volume or that > no storage has been allocated for the file yet. > > FIEMAP_EXTENT_DELALLOC > This will also set FIEMAP_EXTENT_UNKNOWN. > > Delayed allocation - while there is data for this extent, its > physical location has not been allocated yet. > > FIEMAP_EXTENT_UNWRITTEN > Unwritten extent - the extent is allocated but its data has not > been initialized. This indicates the extent’s data will be all > zero if read through the filesystem but the contents are undefined > if read directly from the device. > > [1] https://www.kernel.org/doc/html/latest/filesystems/fiemap.html > > According to its description, f2fs only support > FIEMAP_EXTENT_{UNKNOWN, DELALLOC}, but not support > FIEMAP_EXTENT_UNWRITTEN. No, I don't think so. > > So 009, 092, 094 .. which expects unwritten status from extent will > fail. > > How about disabling those testcase? > > Thanks, > > > > > On 04/05, Chao Yu wrote: > > > xfstest generic/614 fails to run due below reason: > > > > > > generic/614 1s ... [not run] test requires delayed allocation buffered writes > > > > > > The root cause is f2fs tags wrong fiemap flag for delay allocated > > > extent. > > > > > > Quoted from fiemap.h: > > > FIEMAP_EXTENT_UNKNOWN 0x00000002 /* Data location unknown. */ > > > FIEMAP_EXTENT_DELALLOC 0x00000004 /* Location still pending. > > > * Sets EXTENT_UNKNOWN. */ > > > FIEMAP_EXTENT_UNWRITTEN 0x00000800 /* Space allocated, but > > > * no data (i.e. zero). */ > > > > > > FIEMAP_EXTENT_UNWRITTEN means block address is preallocated, but w/o > > > been written any data, which status f2fs is not supported now, for all > > > NEW_ADDR block addresses, it means delay allocated blocks, so let's > > > tag FIEMAP_EXTENT_DELALLOC instead. > > > > > > Testcase: > > > xfs_io -f -c 'pwrite 0 64k' /mnt/f2fs/file; > > > filefrag -v /mnt/f2fs/file > > > > > > Output: > > > - Before > > > Filesystem type is: f2f52010 > > > Fize of /mnt/f2fs/file is 65536 (16 blocks of 4096 bytes) > > > ext: logical_offset: physical_offset: length: expected: flags: > > > 0: 0.. 15: 0.. 15: 16: last,unwritten,merged,eof > > > /mnt/f2fs/file: 1 extent found > > > > > > After: > > > Filesystem type is: f2f52010 > > > File size of /mnt/f2fs/file is 65536 (16 blocks of 4096 bytes) > > > ext: logical_offset: physical_offset: length: expected: flags: > > > 0: 0.. 15: 0.. 0: 0: last,unknown_loc,delalloc,eof > > > /mnt/f2fs/file: 1 extent found > > > > > > Fixes: 7f63eb77af7b ("f2fs: report unwritten area in f2fs_fiemap") > > > Signed-off-by: Chao Yu > > > --- > > > fs/f2fs/data.c | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > > > index 359de650772e..3afc9764743e 100644 > > > --- a/fs/f2fs/data.c > > > +++ b/fs/f2fs/data.c > > > @@ -1995,7 +1995,10 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > > > } > > > if (size) { > > > - flags |= FIEMAP_EXTENT_MERGED; > > > + if (flags & FIEMAP_EXTENT_DELALLOC) > > > + phys = 0; > > > + else > > > + flags |= FIEMAP_EXTENT_MERGED; > > > if (IS_ENCRYPTED(inode)) > > > flags |= FIEMAP_EXTENT_DATA_ENCRYPTED; > > > @@ -2035,7 +2038,7 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > > > size += blks_to_bytes(inode, 1); > > > } > > > } else if (map.m_flags & F2FS_MAP_DELALLOC) { > > > - flags = FIEMAP_EXTENT_UNWRITTEN; > > > + flags = FIEMAP_EXTENT_DELALLOC; > > > } > > > start_blk += bytes_to_blks(inode, size); > > > -- > > > 2.36.1