Re: [Intel-gfx] [PATCH 02/12] drm/i915: Introduce intel_csc_matrix struct

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

> > @@ -294,13 +293,20 @@ static bool ilk_csc_limited_range(const struct intel_crtc_state *crtc_state)
> >   }
> >   
> >   static void ilk_csc_convert_ctm(const struct intel_crtc_state *crtc_state,
> > -				u16 coeffs[9], bool limited_color_range)
> > +				struct intel_csc_matrix *csc,
> > +				bool limited_color_range)
> >   {
> >   	const struct drm_color_ctm *ctm = crtc_state->hw.ctm->data;
> >   	const u64 *input;
> >   	u64 temp[9];
> >   	int i;
> >   
> > +	/* for preoff/postoff */
> > +	if (limited_color_range)
> > +		*csc = ilk_csc_matrix_limited_range;
> > +	else
> > +		*csc = ilk_csc_matrix_identity;
> 
> 
> Lets merge this if block with the below if block, as we are again 
> checking limited_color_range.

I considered that, but didn't really like it. Seemed clearner to
first setup the pre/post offsets, and only then deal with the
input matrix.

-- 
Ville Syrjälä
Intel