From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D357C77B6F for ; Tue, 11 Apr 2023 17:09:04 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pmHUN-0007KH-0m; Tue, 11 Apr 2023 17:09:02 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pmHUJ-0007K1-BT for linux-f2fs-devel@lists.sourceforge.net; Tue, 11 Apr 2023 17:08:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q+Wic3WCe746D9FBgJNDBmH0JggLxTWamlBEaic8IJo=; b=WWs0uKfT/Z9yLZYXE23CM0jBeq 0RUnh6CBqS0KSVNW2OvVmlqb3QtLXgzCXaGh8J2uXFz7KmBX+vTFzkuIH9wCD2Za6d2gZKTzMMAOn bxSixPBm6oEnQe9zDzV0vNaxFXWSWtDzcEhzt3lqnbE4/GB324wdG0oIkWgCP4uMnVGc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Q+Wic3WCe746D9FBgJNDBmH0JggLxTWamlBEaic8IJo=; b=kZJ/NEC1SiTVkhrahH1XvRQqHw F8P87YN95WHAtYnou0Ku9XODirg2wNqEISyXIPhG8DFg3x9kt4+8Sd/1tHLiuEMMnnbOoHda+IxlG zj5hyoIZJZryhTe/D7LzuGIfHzu1pw3EqQgDHZ8/XhpDTAmo23IjSycyeSUbPH2yYNt0=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pmHU9-0005WY-O4 for linux-f2fs-devel@lists.sourceforge.net; Tue, 11 Apr 2023 17:08:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E31E622C8 for ; Tue, 11 Apr 2023 17:08:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB011C433D2; Tue, 11 Apr 2023 17:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681232923; bh=KK2wcAmTXAmRl/Ls32v9Ffjf1eFKoGVvdH85RsyomL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rbDEVlmK/qzdpjete8oaogpFA8aGk48GKwmZlPNYfX4F0fm9cTIp0SsGomAEv3HlA g0a8MOyx2KPODmisHm0IRP822DhZLodA4FOJ3NdHru65czj68gqhH/F5Fk1t5PzVPT mDmGbFhh5nnhfGi9Epa90nSN0Og16VTprHk1WvTW5l6Vf44oh3HauFysQnlr74LRAE 0nhtqsxwzDgeK8Ew7tKmvI7tsA3kK+wCb8fekmGxBA1c2NVgFWuOyIhuWinhHAZoRK iMexVHVLWlKlUwWpASptp+aYa2P8Ib87O0B0IMdmta+QKcIcXDbk6Kv+YzaHBeLwb+ RiQb/1cY3eB7Q== Date: Tue, 11 Apr 2023 10:08:42 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20230405144359.930253-1-chao@kernel.org> <224e8756-7c63-fd53-a0f3-f3e2a7b4c13f@kernel.org> <538fd229-28ae-0ec5-ef07-35d505fbb8a9@kernel.org> <2341db3b-5a40-a9f0-51f1-29a8908e3e98@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2341db3b-5a40-a9f0-51f1-29a8908e3e98@kernel.org> X-Headers-End: 1pmHU9-0005WY-O4 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to tag FIEMAP_EXTENT_DELALLOC in fiemap() for delay allocated extent X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMDQvMTEsIENoYW8gWXUgd3JvdGU6Cj4gT24gMjAyMy80LzExIDE2OjE0LCBDaGFvIFl1IHdy b3RlOgo+ID4gT24gMjAyMy80LzExIDE6NTcsIEphZWdldWsgS2ltIHdyb3RlOgo+ID4gPiBPbiAw NC8wOCwgQ2hhbyBZdSB3cm90ZToKPiA+ID4gPiBPbiAyMDIzLzQvOCA0OjU5LCBKYWVnZXVrIEtp bSB3cm90ZToKPiA+ID4gPiA+IFRoaXMgYnJlYWtzIGdlbmVyaWMvMDA5Pwo+ID4gPiA+IAo+ID4g PiA+IEkgZ3Vlc3MgaXQgaXMgYXMgZXhwZWN0ZWQ/Cj4gPiA+ID4gCj4gPiA+ID4gUGxlYXNlIGNo ZWNrIGRlc2NyaXB0aW9uIG9mIGZpZW1hcCBpb2N0bCBtYW51YWwgZnJvbSBbMV06Cj4gPiA+ID4g Cj4gPiA+ID4gRklFTUFQX0VYVEVOVF9VTktOT1dOCj4gPiA+ID4gVGhlIGxvY2F0aW9uIG9mIHRo aXMgZXh0ZW50IGlzIGN1cnJlbnRseSB1bmtub3duLiBUaGlzIG1heQo+ID4gPiA+IGluZGljYXRl IHRoZSBkYXRhIGlzIHN0b3JlZCBvbiBhbiBpbmFjY2Vzc2libGUgdm9sdW1lIG9yIHRoYXQKPiA+ ID4gPiBubyBzdG9yYWdlIGhhcyBiZWVuIGFsbG9jYXRlZCBmb3IgdGhlIGZpbGUgeWV0Lgo+ID4g PiA+IAo+ID4gPiA+IEZJRU1BUF9FWFRFTlRfREVMQUxMT0MKPiA+ID4gPiBUaGlzIHdpbGwgYWxz byBzZXQgRklFTUFQX0VYVEVOVF9VTktOT1dOLgo+ID4gPiA+IAo+ID4gPiA+IERlbGF5ZWQgYWxs b2NhdGlvbiAtIHdoaWxlIHRoZXJlIGlzIGRhdGEgZm9yIHRoaXMgZXh0ZW50LCBpdHMKPiA+ID4g PiBwaHlzaWNhbCBsb2NhdGlvbiBoYXMgbm90IGJlZW4gYWxsb2NhdGVkIHlldC4KPiA+ID4gPiAK PiA+ID4gPiBGSUVNQVBfRVhURU5UX1VOV1JJVFRFTgo+ID4gPiA+IFVud3JpdHRlbiBleHRlbnQg LSB0aGUgZXh0ZW50IGlzIGFsbG9jYXRlZCBidXQgaXRzIGRhdGEgaGFzIG5vdAo+ID4gPiA+IGJl ZW4gaW5pdGlhbGl6ZWQuIFRoaXMgaW5kaWNhdGVzIHRoZSBleHRlbnTigJlzIGRhdGEgd2lsbCBi ZSBhbGwKPiA+ID4gPiB6ZXJvIGlmIHJlYWQgdGhyb3VnaCB0aGUgZmlsZXN5c3RlbSBidXQgdGhl IGNvbnRlbnRzIGFyZSB1bmRlZmluZWQKPiA+ID4gPiBpZiByZWFkIGRpcmVjdGx5IGZyb20gdGhl IGRldmljZS4KPiA+ID4gPiAKPiA+ID4gPiBbMV0gaHR0cHM6Ly93d3cua2VybmVsLm9yZy9kb2Mv aHRtbC9sYXRlc3QvZmlsZXN5c3RlbXMvZmllbWFwLmh0bWwKPiA+ID4gPiAKPiA+ID4gPiBBY2Nv cmRpbmcgdG8gaXRzIGRlc2NyaXB0aW9uLCBmMmZzIG9ubHkgc3VwcG9ydAo+ID4gPiA+IEZJRU1B UF9FWFRFTlRfe1VOS05PV04sIERFTEFMTE9DfSwgYnV0IG5vdCBzdXBwb3J0Cj4gPiA+ID4gRklF TUFQX0VYVEVOVF9VTldSSVRURU4uCj4gPiA+IAo+ID4gPiBObywgSSBkb24ndCB0aGluayBzby4K PiA+IAo+ID4gSmFlZ2V1aywKPiA+IAo+ID4gQ291bGQgeW91IHBsZWFzZSBjaGVjayB0aGUgZGV0 YWlsZWQgZGVzY3JpcHRpb24gb2YgRklFTUFQX0VYVEVOVF9VTldSSVRURU4/Cj4gPiBUaGUgZmxh ZyBpbmRpY2F0ZXMgdHdvIGNvbmRpdGlvbnM6Cj4gPiAxLiBvbi1kaXNrIGJsa2FkZHJzIHdlcmUg YWxsb2NhdGVkIGZvciBleHRlbnQsIGFuZCB0aGUgZXh0ZW50IGlzIHRhZ2dlZCBhcwo+ID4gdW53 cml0dGVuIHN0YXR1cy4KPiA+IDIuIGRhdGEgcmVhZGVkIG9uIHRob3NlIGJsb2NrcyB3aWxsIGJl IGFsbCB6ZXJvLgo+IAo+IFNvcnJ5LCBJIG1lYW46Cj4gCj4gMS4gb24tZGlzayBibGthZGRycyB3 ZXJlIGFsbG9jYXRlZCBmb3IgZXh0ZW50Owo+IDIuIGV4dGVudCBpcyB0YWdnZWQgYXMgdW53cml0 dGVuIHN0YXR1cywgZGF0YSByZWFkZWQgb24gdGhvc2UgYmxvY2tzIHdpbGwgYmUKPiBhbGwgemVy by4KCkkgd2FzIHRoaW5raW5nIGZhbGxvY2F0ZS9waW4gY2FzZXMgdG8gZ2l2ZSB6ZXJvIGRhdGEu IEJ1dCwgd2UgbWF5IG5lZWQgdG8gY2hlY2sKdGhlIHNwYWNlIGRpc2NhcmRlZCBzZWN1cmVseSBv ciBkaXNrIHN1cHBvcnQ/Cgo+IAo+IFRoYW5rcywKPiAKPiA+IAo+ID4gU28sIGxldCdzIGNoZWNr IGYyZnMnIHN0YXR1czoKPiA+IC0gZmFsbG9jYXRlIG9ubHkgcmVzZXJ2ZSB2YWxpZCBibG9jayBj b3VudCBhbmQgc2V0IE5FV19BRERSIGluIGRub2RlLCBzbwo+ID4gaXQgZG9lcyBub3QgbWF0Y2gg Y29uZGl0aW9uIDEpCj4gPiAtIHBpbiAmIGZhbGxvY2F0ZSBwcmVhbGxvY2F0ZXMgYmxrYWRkcnMg YW5kIHNldCBibGthZGRycyBpbiBkbm9kZSwgYnV0Cj4gPiBjb250ZW50IG9uIHRob3NlIGJsa2Fk ZHJzIG1heSBjb250YWluIHplcm8gb3IgcmFuZG9tIGRhdGEsIHNvIGl0IGRvZXMgbm90Cj4gPiBt YXRjaMKgIGNvbmRpdGlvbiAyKQo+ID4gCj4gPiBDaHJpc3RvcGggZGVzY3JpYmVzIHRoaXMgaXNz dWUgaW4gYmVsb3cgcGF0Y2ggYXMgd2VsbCwgeW91IGNhbiBjaGVjayBpdC4KPiA+IGRhOGM3ZmVj YzljNyAoImYyZnM6IHJlbmFtZSBGMkZTX01BUF9VTldSSVRURU4gdG8gRjJGU19NQVBfREVMQUxM T0MiKQo+ID4gCj4gPiBBbSBJIG1pc3Npbmcgc29tZXRoaW5nPwo+ID4gCj4gPiBUaGFua3MsCj4g PiAKPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gU28gMDA5LCAwOTIsIDA5NCAuLiB3aGljaCBleHBl Y3RzIHVud3JpdHRlbiBzdGF0dXMgZnJvbSBleHRlbnQgd2lsbAo+ID4gPiA+IGZhaWwuCj4gPiA+ ID4gCj4gPiA+ID4gSG93IGFib3V0IGRpc2FibGluZyB0aG9zZSB0ZXN0Y2FzZT8KPiA+ID4gPiAK PiA+ID4gPiBUaGFua3MsCj4gPiA+ID4gCj4gPiA+ID4gPiAKPiA+ID4gPiA+IE9uIDA0LzA1LCBD aGFvIFl1IHdyb3RlOgo+ID4gPiA+ID4gPiB4ZnN0ZXN0IGdlbmVyaWMvNjE0IGZhaWxzIHRvIHJ1 biBkdWUgYmVsb3cgcmVhc29uOgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gZ2VuZXJpYy82MTQg MXMgLi4uIFtub3QgcnVuXSB0ZXN0IHJlcXVpcmVzIGRlbGF5ZWQgYWxsb2NhdGlvbiBidWZmZXJl ZCB3cml0ZXMKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFRoZSByb290IGNhdXNlIGlzIGYyZnMg dGFncyB3cm9uZyBmaWVtYXAgZmxhZyBmb3IgZGVsYXkgYWxsb2NhdGVkCj4gPiA+ID4gPiA+IGV4 dGVudC4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFF1b3RlZCBmcm9tIGZpZW1hcC5oOgo+ID4g PiA+ID4gPiBGSUVNQVBfRVhURU5UX1VOS05PV07CoMKgwqDCoMKgwqDCoCAweDAwMDAwMDAyIC8q IERhdGEgbG9jYXRpb24gdW5rbm93bi4gKi8KPiA+ID4gPiA+ID4gRklFTUFQX0VYVEVOVF9ERUxB TExPQ8KgwqDCoMKgwqDCoMKgIDB4MDAwMDAwMDQgLyogTG9jYXRpb24gc3RpbGwgcGVuZGluZy4K PiA+ID4gPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgICogU2V0cyBFWFRFTlRfVU5LTk9XTi4gKi8KPiA+ID4gPiA+ID4gRklFTUFQX0VY VEVOVF9VTldSSVRURU7CoMKgwqDCoMKgwqDCoCAweDAwMDAwODAwIC8qIFNwYWNlIGFsbG9jYXRl ZCwgYnV0Cj4gPiA+ID4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAqIG5vIGRhdGEgKGkuZS4gemVybykuICovCj4gPiA+ID4gPiA+IAo+ ID4gPiA+ID4gPiBGSUVNQVBfRVhURU5UX1VOV1JJVFRFTiBtZWFucyBibG9jayBhZGRyZXNzIGlz IHByZWFsbG9jYXRlZCwgYnV0IHcvbwo+ID4gPiA+ID4gPiBiZWVuIHdyaXR0ZW4gYW55IGRhdGEs IHdoaWNoIHN0YXR1cyBmMmZzIGlzIG5vdCBzdXBwb3J0ZWQgbm93LCBmb3IgYWxsCj4gPiA+ID4g PiA+IE5FV19BRERSIGJsb2NrIGFkZHJlc3NlcywgaXQgbWVhbnMgZGVsYXkgYWxsb2NhdGVkIGJs b2Nrcywgc28gbGV0J3MKPiA+ID4gPiA+ID4gdGFnIEZJRU1BUF9FWFRFTlRfREVMQUxMT0MgaW5z dGVhZC4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFRlc3RjYXNlOgo+ID4gPiA+ID4gPiB4ZnNf aW8gLWYgLWMgJ3B3cml0ZSAwIDY0aycgL21udC9mMmZzL2ZpbGU7Cj4gPiA+ID4gPiA+IGZpbGVm cmFnIC12IC9tbnQvZjJmcy9maWxlCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBPdXRwdXQ6Cj4g PiA+ID4gPiA+IC0gQmVmb3JlCj4gPiA+ID4gPiA+IEZpbGVzeXN0ZW0gdHlwZSBpczogZjJmNTIw MTAKPiA+ID4gPiA+ID4gRml6ZSBvZiAvbW50L2YyZnMvZmlsZSBpcyA2NTUzNiAoMTYgYmxvY2tz IG9mIDQwOTYgYnl0ZXMpCj4gPiA+ID4gPiA+IMKgwqAgZXh0OsKgwqDCoMKgIGxvZ2ljYWxfb2Zm c2V0OsKgwqDCoMKgwqDCoMKgIHBoeXNpY2FsX29mZnNldDogbGVuZ3RoOsKgwqAgZXhwZWN0ZWQ6 IGZsYWdzOgo+ID4gPiA+ID4gPiDCoMKgwqDCoCAwOsKgwqDCoMKgwqDCoMKgIDAuLsKgwqDCoMKg wqAgMTU6wqDCoMKgwqDCoMKgwqDCoMKgIDAuLsKgwqDCoMKgwqDCoMKgIDE1OsKgwqDCoMKgIDE2 OsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBsYXN0LHVud3JpdHRlbixtZXJnZWQsZW9mCj4gPiA+ ID4gPiA+IC9tbnQvZjJmcy9maWxlOiAxIGV4dGVudCBmb3VuZAo+ID4gPiA+ID4gPiAKPiA+ID4g PiA+ID4gQWZ0ZXI6Cj4gPiA+ID4gPiA+IEZpbGVzeXN0ZW0gdHlwZSBpczogZjJmNTIwMTAKPiA+ ID4gPiA+ID4gRmlsZSBzaXplIG9mIC9tbnQvZjJmcy9maWxlIGlzIDY1NTM2ICgxNiBibG9ja3Mg b2YgNDA5NiBieXRlcykKPiA+ID4gPiA+ID4gwqDCoCBleHQ6wqDCoMKgwqAgbG9naWNhbF9vZmZz ZXQ6wqDCoMKgwqDCoMKgwqAgcGh5c2ljYWxfb2Zmc2V0OiBsZW5ndGg6wqDCoCBleHBlY3RlZDog ZmxhZ3M6Cj4gPiA+ID4gPiA+IMKgwqDCoMKgIDA6wqDCoMKgwqDCoMKgwqAgMC4uwqDCoMKgwqDC oCAxNTrCoMKgwqDCoMKgwqDCoMKgwqAgMC4uwqDCoMKgwqDCoMKgwqDCoCAwOsKgwqDCoMKgwqAg MDrCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbGFzdCx1bmtub3duX2xvYyxkZWxhbGxvYyxlb2YK PiA+ID4gPiA+ID4gL21udC9mMmZzL2ZpbGU6IDEgZXh0ZW50IGZvdW5kCj4gPiA+ID4gPiA+IAo+ ID4gPiA+ID4gPiBGaXhlczogN2Y2M2ViNzdhZjdiICgiZjJmczogcmVwb3J0IHVud3JpdHRlbiBh cmVhIGluIGYyZnNfZmllbWFwIikKPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogQ2hhbyBZdSA8 Y2hhb0BrZXJuZWwub3JnPgo+ID4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+ID4gwqDCoCBmcy9mMmZz L2RhdGEuYyB8IDcgKysrKystLQo+ID4gPiA+ID4gPiDCoMKgIDEgZmlsZSBjaGFuZ2VkLCA1IGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBkaWZm IC0tZ2l0IGEvZnMvZjJmcy9kYXRhLmMgYi9mcy9mMmZzL2RhdGEuYwo+ID4gPiA+ID4gPiBpbmRl eCAzNTlkZTY1MDc3MmUuLjNhZmM5NzY0NzQzZSAxMDA2NDQKPiA+ID4gPiA+ID4gLS0tIGEvZnMv ZjJmcy9kYXRhLmMKPiA+ID4gPiA+ID4gKysrIGIvZnMvZjJmcy9kYXRhLmMKPiA+ID4gPiA+ID4g QEAgLTE5OTUsNyArMTk5NSwxMCBAQCBpbnQgZjJmc19maWVtYXAoc3RydWN0IGlub2RlICppbm9k ZSwgc3RydWN0IGZpZW1hcF9leHRlbnRfaW5mbyAqZmllaW5mbywKPiA+ID4gPiA+ID4gwqDCoMKg wqDCoMKgIH0KPiA+ID4gPiA+ID4gwqDCoMKgwqDCoMKgIGlmIChzaXplKSB7Cj4gPiA+ID4gPiA+ IC3CoMKgwqDCoMKgwqDCoCBmbGFncyB8PSBGSUVNQVBfRVhURU5UX01FUkdFRDsKPiA+ID4gPiA+ ID4gK8KgwqDCoMKgwqDCoMKgIGlmIChmbGFncyAmIEZJRU1BUF9FWFRFTlRfREVMQUxMT0MpCj4g PiA+ID4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBoeXMgPSAwOwo+ID4gPiA+ID4gPiAr wqDCoMKgwqDCoMKgwqAgZWxzZQo+ID4gPiA+ID4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBm bGFncyB8PSBGSUVNQVBfRVhURU5UX01FUkdFRDsKPiA+ID4gPiA+ID4gwqDCoMKgwqDCoMKgwqDC oMKgwqAgaWYgKElTX0VOQ1JZUFRFRChpbm9kZSkpCj4gPiA+ID4gPiA+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgZmxhZ3MgfD0gRklFTUFQX0VYVEVOVF9EQVRBX0VOQ1JZUFRFRDsKPiA+ ID4gPiA+ID4gQEAgLTIwMzUsNyArMjAzOCw3IEBAIGludCBmMmZzX2ZpZW1hcChzdHJ1Y3QgaW5v ZGUgKmlub2RlLCBzdHJ1Y3QgZmllbWFwX2V4dGVudF9pbmZvICpmaWVpbmZvLAo+ID4gPiA+ID4g PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc2l6ZSArPSBibGtzX3RvX2J5 dGVzKGlub2RlLCAxKTsKPiA+ID4gPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9 Cj4gPiA+ID4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0gZWxzZSBpZiAobWFwLm1fZmxhZ3Mg JiBGMkZTX01BUF9ERUxBTExPQykgewo+ID4gPiA+ID4gPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBmbGFncyA9IEZJRU1BUF9FWFRFTlRfVU5XUklUVEVOOwo+ID4gPiA+ID4gPiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBmbGFncyA9IEZJRU1BUF9FWFRFTlRfREVMQUxMT0M7Cj4gPiA+ID4gPiA+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KPiA+ID4gPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqAg c3RhcnRfYmxrICs9IGJ5dGVzX3RvX2Jsa3MoaW5vZGUsIHNpemUpOwo+ID4gPiA+ID4gPiAtLSAK PiA+ID4gPiA+ID4gMi4zNi4xCj4gPiAKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiA+IExpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0 Cj4gPiBMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldAo+ID4gaHR0cHM6Ly9s aXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LWYyZnMt ZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0 Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A4FC76196 for ; Tue, 11 Apr 2023 17:08:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229840AbjDKRIu (ORCPT ); Tue, 11 Apr 2023 13:08:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229834AbjDKRIq (ORCPT ); Tue, 11 Apr 2023 13:08:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF0A84489 for ; Tue, 11 Apr 2023 10:08:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A25460EAD for ; Tue, 11 Apr 2023 17:08:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB011C433D2; Tue, 11 Apr 2023 17:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681232923; bh=KK2wcAmTXAmRl/Ls32v9Ffjf1eFKoGVvdH85RsyomL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rbDEVlmK/qzdpjete8oaogpFA8aGk48GKwmZlPNYfX4F0fm9cTIp0SsGomAEv3HlA g0a8MOyx2KPODmisHm0IRP822DhZLodA4FOJ3NdHru65czj68gqhH/F5Fk1t5PzVPT mDmGbFhh5nnhfGi9Epa90nSN0Og16VTprHk1WvTW5l6Vf44oh3HauFysQnlr74LRAE 0nhtqsxwzDgeK8Ew7tKmvI7tsA3kK+wCb8fekmGxBA1c2NVgFWuOyIhuWinhHAZoRK iMexVHVLWlKlUwWpASptp+aYa2P8Ib87O0B0IMdmta+QKcIcXDbk6Kv+YzaHBeLwb+ RiQb/1cY3eB7Q== Date: Tue, 11 Apr 2023 10:08:42 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to tag FIEMAP_EXTENT_DELALLOC in fiemap() for delay allocated extent Message-ID: References: <20230405144359.930253-1-chao@kernel.org> <224e8756-7c63-fd53-a0f3-f3e2a7b4c13f@kernel.org> <538fd229-28ae-0ec5-ef07-35d505fbb8a9@kernel.org> <2341db3b-5a40-a9f0-51f1-29a8908e3e98@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2341db3b-5a40-a9f0-51f1-29a8908e3e98@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/11, Chao Yu wrote: > On 2023/4/11 16:14, Chao Yu wrote: > > On 2023/4/11 1:57, Jaegeuk Kim wrote: > > > On 04/08, Chao Yu wrote: > > > > On 2023/4/8 4:59, Jaegeuk Kim wrote: > > > > > This breaks generic/009? > > > > > > > > I guess it is as expected? > > > > > > > > Please check description of fiemap ioctl manual from [1]: > > > > > > > > FIEMAP_EXTENT_UNKNOWN > > > > The location of this extent is currently unknown. This may > > > > indicate the data is stored on an inaccessible volume or that > > > > no storage has been allocated for the file yet. > > > > > > > > FIEMAP_EXTENT_DELALLOC > > > > This will also set FIEMAP_EXTENT_UNKNOWN. > > > > > > > > Delayed allocation - while there is data for this extent, its > > > > physical location has not been allocated yet. > > > > > > > > FIEMAP_EXTENT_UNWRITTEN > > > > Unwritten extent - the extent is allocated but its data has not > > > > been initialized. This indicates the extent’s data will be all > > > > zero if read through the filesystem but the contents are undefined > > > > if read directly from the device. > > > > > > > > [1] https://www.kernel.org/doc/html/latest/filesystems/fiemap.html > > > > > > > > According to its description, f2fs only support > > > > FIEMAP_EXTENT_{UNKNOWN, DELALLOC}, but not support > > > > FIEMAP_EXTENT_UNWRITTEN. > > > > > > No, I don't think so. > > > > Jaegeuk, > > > > Could you please check the detailed description of FIEMAP_EXTENT_UNWRITTEN? > > The flag indicates two conditions: > > 1. on-disk blkaddrs were allocated for extent, and the extent is tagged as > > unwritten status. > > 2. data readed on those blocks will be all zero. > > Sorry, I mean: > > 1. on-disk blkaddrs were allocated for extent; > 2. extent is tagged as unwritten status, data readed on those blocks will be > all zero. I was thinking fallocate/pin cases to give zero data. But, we may need to check the space discarded securely or disk support? > > Thanks, > > > > > So, let's check f2fs' status: > > - fallocate only reserve valid block count and set NEW_ADDR in dnode, so > > it does not match condition 1) > > - pin & fallocate preallocates blkaddrs and set blkaddrs in dnode, but > > content on those blkaddrs may contain zero or random data, so it does not > > match  condition 2) > > > > Christoph describes this issue in below patch as well, you can check it. > > da8c7fecc9c7 ("f2fs: rename F2FS_MAP_UNWRITTEN to F2FS_MAP_DELALLOC") > > > > Am I missing something? > > > > Thanks, > > > > > > > > > > > > > So 009, 092, 094 .. which expects unwritten status from extent will > > > > fail. > > > > > > > > How about disabling those testcase? > > > > > > > > Thanks, > > > > > > > > > > > > > > On 04/05, Chao Yu wrote: > > > > > > xfstest generic/614 fails to run due below reason: > > > > > > > > > > > > generic/614 1s ... [not run] test requires delayed allocation buffered writes > > > > > > > > > > > > The root cause is f2fs tags wrong fiemap flag for delay allocated > > > > > > extent. > > > > > > > > > > > > Quoted from fiemap.h: > > > > > > FIEMAP_EXTENT_UNKNOWN        0x00000002 /* Data location unknown. */ > > > > > > FIEMAP_EXTENT_DELALLOC        0x00000004 /* Location still pending. > > > > > >                             * Sets EXTENT_UNKNOWN. */ > > > > > > FIEMAP_EXTENT_UNWRITTEN        0x00000800 /* Space allocated, but > > > > > >                             * no data (i.e. zero). */ > > > > > > > > > > > > FIEMAP_EXTENT_UNWRITTEN means block address is preallocated, but w/o > > > > > > been written any data, which status f2fs is not supported now, for all > > > > > > NEW_ADDR block addresses, it means delay allocated blocks, so let's > > > > > > tag FIEMAP_EXTENT_DELALLOC instead. > > > > > > > > > > > > Testcase: > > > > > > xfs_io -f -c 'pwrite 0 64k' /mnt/f2fs/file; > > > > > > filefrag -v /mnt/f2fs/file > > > > > > > > > > > > Output: > > > > > > - Before > > > > > > Filesystem type is: f2f52010 > > > > > > Fize of /mnt/f2fs/file is 65536 (16 blocks of 4096 bytes) > > > > > >    ext:     logical_offset:        physical_offset: length:   expected: flags: > > > > > >      0:        0..      15:          0..        15:     16:             last,unwritten,merged,eof > > > > > > /mnt/f2fs/file: 1 extent found > > > > > > > > > > > > After: > > > > > > Filesystem type is: f2f52010 > > > > > > File size of /mnt/f2fs/file is 65536 (16 blocks of 4096 bytes) > > > > > >    ext:     logical_offset:        physical_offset: length:   expected: flags: > > > > > >      0:        0..      15:          0..         0:      0:             last,unknown_loc,delalloc,eof > > > > > > /mnt/f2fs/file: 1 extent found > > > > > > > > > > > > Fixes: 7f63eb77af7b ("f2fs: report unwritten area in f2fs_fiemap") > > > > > > Signed-off-by: Chao Yu > > > > > > --- > > > > > >    fs/f2fs/data.c | 7 +++++-- > > > > > >    1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > > > > > > index 359de650772e..3afc9764743e 100644 > > > > > > --- a/fs/f2fs/data.c > > > > > > +++ b/fs/f2fs/data.c > > > > > > @@ -1995,7 +1995,10 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > > > > > >        } > > > > > >        if (size) { > > > > > > -        flags |= FIEMAP_EXTENT_MERGED; > > > > > > +        if (flags & FIEMAP_EXTENT_DELALLOC) > > > > > > +            phys = 0; > > > > > > +        else > > > > > > +            flags |= FIEMAP_EXTENT_MERGED; > > > > > >            if (IS_ENCRYPTED(inode)) > > > > > >                flags |= FIEMAP_EXTENT_DATA_ENCRYPTED; > > > > > > @@ -2035,7 +2038,7 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > > > > > >                    size += blks_to_bytes(inode, 1); > > > > > >                } > > > > > >            } else if (map.m_flags & F2FS_MAP_DELALLOC) { > > > > > > -            flags = FIEMAP_EXTENT_UNWRITTEN; > > > > > > +            flags = FIEMAP_EXTENT_DELALLOC; > > > > > >            } > > > > > >            start_blk += bytes_to_blks(inode, size); > > > > > > -- > > > > > > 2.36.1 > > > > > > _______________________________________________ > > Linux-f2fs-devel mailing list > > Linux-f2fs-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel