From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: zyjzyj2000@gmail.com, jhack@hpe.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next 1/1] RDMA-rxe: Allow retry sends for rdma read responses
Date: Wed, 12 Apr 2023 13:05:09 -0300 [thread overview]
Message-ID: <ZDbWtUMQGS3q1GSU@nvidia.com> (raw)
In-Reply-To: <20230215224419.9195-2-rpearsonhpe@gmail.com>
On Wed, Feb 15, 2023 at 04:44:21PM -0600, Bob Pearson wrote:
> @@ -937,9 +987,15 @@ static enum resp_states read_reply(struct rxe_qp *qp,
> }
>
> err = rxe_xmit_packet(qp, &ack_pkt, skb);
> - if (err)
> + delay = read_retry_delay(qp, err);
> + if (err == -EAGAIN) {
> + udelay(delay);
I'd be happier with this patch if it wasn't a udelay here, spinning
hoping the ip stack progresses just feels wrong
Can't this use a timer or something? Re-rx the packet generating the
reply?
Jason
prev parent reply other threads:[~2023-04-12 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 22:44 [PATCH for-next 0/1] RDMA-rxe: Allow retry sends for rdma read responses Bob Pearson
2023-02-15 22:44 ` [PATCH for-next 1/1] " Bob Pearson
2023-04-12 16:05 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDbWtUMQGS3q1GSU@nvidia.com \
--to=jgg@nvidia.com \
--cc=jhack@hpe.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.