All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, patches@lists.linux.dev,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] driver core: Don't require dynamic_debug for initcall_debug probe timing
Date: Wed, 12 Apr 2023 17:15:01 -0700	[thread overview]
Message-ID: <ZDdJhaZibUC0/nfc@google.com> (raw)
In-Reply-To: <20230412225842.3196599-1-swboyd@chromium.org>

On Wed, Apr 12, 2023 at 03:58:42PM -0700, Stephen Boyd wrote:
> Don't require the use of dynamic debug (or modification of the kernel to
> add a #define DEBUG to the top of this file) to get the printk message
> about driver probe timing. This printk is only emitted when
> initcall_debug is enabled on the kernel commandline, and it isn't
> immediately obvious that you have to do something else to debug boot
> timing issues related to driver probe. Add a comment too so it doesn't
> get converted back to pr_debug().
> 
> Fixes: eb7fbc9fb118 ("driver core: Add missing '\n' in log messages")
> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Cc: Brian Norris <briannorris@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  drivers/base/dd.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Reviewed-by: Brian Norris <briannorris@chromium.org>

      parent reply	other threads:[~2023-04-13  0:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 22:58 [PATCH] driver core: Don't require dynamic_debug for initcall_debug probe timing Stephen Boyd
2023-04-12 23:02 ` Randy Dunlap
2023-04-13  0:15 ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZDdJhaZibUC0/nfc@google.com \
    --to=briannorris@chromium.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.