From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B93C77B6E for ; Fri, 14 Apr 2023 06:06:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229591AbjDNGGR (ORCPT ); Fri, 14 Apr 2023 02:06:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbjDNGGP (ORCPT ); Fri, 14 Apr 2023 02:06:15 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 405B340FB; Thu, 13 Apr 2023 23:06:15 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id p17so6237080pla.3; Thu, 13 Apr 2023 23:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681452375; x=1684044375; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nt3V2+mv4t801ZlOZsHsJ+sMq7Uehw8dmEUN92ABS60=; b=HoGqEkjeNtcP2rPL1p0y+FJIxoFVGTA5z6A2hPsrtax4RiKwU5poiwvth7vyrTIBJn 3YZn3AGtuXrm8TB5J9gKjgfMiiJLaCU8jPiH/FQTcwfZ4N0ujU/K6sqWtA80eEuY2qKJ +TsoFY50tz40tx87JjDxeXkjpgA1HLocoZ4ksPqgxKXyQIoILFfF9NsjjEtTKeWMqPY1 g5L8oaVzNqQZK0iEHIAc46ZCvXxujf6R91IjWajUMcm/twuvW+bUaAmXi0LpM8jEzE+W HjX3oCEBBxWDGW0XMB9fLlyl8hALQoMwf5+m1cWOXoA8knVn0cxE95ST/FrgpQAWagBt cnUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681452375; x=1684044375; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nt3V2+mv4t801ZlOZsHsJ+sMq7Uehw8dmEUN92ABS60=; b=T9dfKDt/e+AqDfzdyzlXQQ1Saju/lODEQ669BGMp07++X5RI+jRacg7n0xmHJS3RRt MzIBkhK8tn5d47g6a9d/S6mc08/0EkzUrDK6AOdLBcLsXuMpa74mhX6H30s/ZrZvaXWc jxdr4utnsTZYDgaVG+VZsstnb1XEf9n98UIOf4i111Hfg/QmcjL25y621BY9lEw/zrhg inTtTg8j3i40YLDcn5NDmdrfqp4/AzP6A1assxrODNxwvleDg5r6Fzmn8QSlwzhupiOU 1OnaX6z6zoZAsiBQcOr3JRxg6UHZNzLw9usFYz/TiW6b7JtHixN2B8B1nXJ0oTWC11R9 QTNQ== X-Gm-Message-State: AAQBX9c0mBDBkuI6XaceNUWTYbU4nXxEVEdJfBXHD9aR9Jwg8xkjKcX1 fHBoT8gDySXJjA2/pF+OrLJR1k3uXm7+tA== X-Google-Smtp-Source: AKy350am8vILPKKjsKr52mYLRSslvwQR+wsgesWZfuKdo0gQ2RhDaTJUcXxdcEs77Xu3IytxIKvRgA== X-Received: by 2002:a17:90b:17c7:b0:246:f9f1:ad17 with SMTP id me7-20020a17090b17c700b00246f9f1ad17mr4145791pjb.40.1681452374443; Thu, 13 Apr 2023 23:06:14 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:5142:7eb2:ace5:60c1]) by smtp.gmail.com with ESMTPSA id z4-20020a17090a540400b002407c8f89aasm2195283pjh.24.2023.04.13.23.06.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 23:06:13 -0700 (PDT) Date: Thu, 13 Apr 2023 23:06:10 -0700 From: Dmitry Torokhov To: Miaoqian Lin Cc: Florian Fainelli , Broadcom internal kernel review list , Rob Herring , Eric Anholt , Nicolas Saenz Julienne , linux-input@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] input: raspberrypi-ts: Fix refcount leak in rpi_ts_probe Message-ID: References: <20221223074657.810346-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221223074657.810346-1-linmq006@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, Dec 23, 2022 at 11:46:53AM +0400, Miaoqian Lin wrote: > rpi_firmware_get() take reference, we need to release it in error paths > as well. Use devm_rpi_firmware_get() helper to handling the resources. > Also remove the existing rpi_firmware_put(). > > Fixes: 0b9f28fed3f7 ("Input: add official Raspberry Pi's touchscreen driver") > Fixes: 3b8ddff780b7 ("input: raspberrypi-ts: Release firmware handle when not needed") > Signed-off-by: Miaoqian Lin Applied, thank you. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 622FDC77B6E for ; Fri, 14 Apr 2023 06:07:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qDB600Ny+Grw4U1wS8qBttiKOmi4TuIZnhgFRUjD7R0=; b=xtFaKXKYjWkNVC g0wt6q/Q9ShXtuujIh46lL1aUPUBHHpG3MIJI6wq4JjPdUKxGGamyaqCOVdwDOW5u/heJ2KiPL9gE i5f4nGsERt5NqrPBlz/nuYWudo4FkcA0yxPguuv70CjIavOfD4U3yeroyZVptLfAfVDmwXdq/R2j/ 7U0LQv9V0DZoy2P68lj18/38buvLzS5SRY9exO72Wo51msxn9CuW6WB/nPnhz+O+4Vk6RlHxvprzK 6wgiNPpy8B2kKygt/vSBwGVcCBWSRtJjoADj7q4esvY4Ukk5NzdjYlTv2e9a5jkm73hvmTD6Pncm6 TobQkDUyRXRE3xCf1CwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnCZv-008Qkm-06; Fri, 14 Apr 2023 06:06:35 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnCZr-008QjJ-0j; Fri, 14 Apr 2023 06:06:32 +0000 Received: by mail-pj1-x102d.google.com with SMTP id y11-20020a17090a600b00b0024693e96b58so16599205pji.1; Thu, 13 Apr 2023 23:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681452375; x=1684044375; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nt3V2+mv4t801ZlOZsHsJ+sMq7Uehw8dmEUN92ABS60=; b=HoGqEkjeNtcP2rPL1p0y+FJIxoFVGTA5z6A2hPsrtax4RiKwU5poiwvth7vyrTIBJn 3YZn3AGtuXrm8TB5J9gKjgfMiiJLaCU8jPiH/FQTcwfZ4N0ujU/K6sqWtA80eEuY2qKJ +TsoFY50tz40tx87JjDxeXkjpgA1HLocoZ4ksPqgxKXyQIoILFfF9NsjjEtTKeWMqPY1 g5L8oaVzNqQZK0iEHIAc46ZCvXxujf6R91IjWajUMcm/twuvW+bUaAmXi0LpM8jEzE+W HjX3oCEBBxWDGW0XMB9fLlyl8hALQoMwf5+m1cWOXoA8knVn0cxE95ST/FrgpQAWagBt cnUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681452375; x=1684044375; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nt3V2+mv4t801ZlOZsHsJ+sMq7Uehw8dmEUN92ABS60=; b=OqOAKVekzGE2gPTA6IqCqr8J/XavB2BEmzAISewHIoj38JURsBfNR5ctnZREwdf4wq LD2ddFxckO32wyIX8U/7h3ihmRKaLpNime1Zl0F7oM+5QxA5CkIDi9hckmbW9b/MHDal RKd1LAxUOVMIcOo0sWlbyKbQYQKl9hdVjS1RuzJZQgoSCd8vfDvbGQtikkw4FCfTon10 ECGk/wsMSIgOPyuE4RdTo/VIv7WcTtneomBKJ7LSGV6jydXBCnN1SwrUYuLk6i9xM4vE uOzZO2fuxeKPDNK1XWNB24tVRR2RSWucBTvHq9eFbV6pbICWgKQ/pwabgasuP2BH14Mv K2pQ== X-Gm-Message-State: AAQBX9eCEJoN36Dt3Gi3IlDEDLY2kfhKbiNedUGh7ZbSOCYqCyuMp4bv 8kf5xcLGzTe0YF8AK2ZdLqI= X-Google-Smtp-Source: AKy350am8vILPKKjsKr52mYLRSslvwQR+wsgesWZfuKdo0gQ2RhDaTJUcXxdcEs77Xu3IytxIKvRgA== X-Received: by 2002:a17:90b:17c7:b0:246:f9f1:ad17 with SMTP id me7-20020a17090b17c700b00246f9f1ad17mr4145791pjb.40.1681452374443; Thu, 13 Apr 2023 23:06:14 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:5142:7eb2:ace5:60c1]) by smtp.gmail.com with ESMTPSA id z4-20020a17090a540400b002407c8f89aasm2195283pjh.24.2023.04.13.23.06.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 23:06:13 -0700 (PDT) Date: Thu, 13 Apr 2023 23:06:10 -0700 From: Dmitry Torokhov To: Miaoqian Lin Cc: Florian Fainelli , Broadcom internal kernel review list , Rob Herring , Eric Anholt , Nicolas Saenz Julienne , linux-input@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] input: raspberrypi-ts: Fix refcount leak in rpi_ts_probe Message-ID: References: <20221223074657.810346-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221223074657.810346-1-linmq006@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_230631_266900_320DDA46 X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 23, 2022 at 11:46:53AM +0400, Miaoqian Lin wrote: > rpi_firmware_get() take reference, we need to release it in error paths > as well. Use devm_rpi_firmware_get() helper to handling the resources. > Also remove the existing rpi_firmware_put(). > > Fixes: 0b9f28fed3f7 ("Input: add official Raspberry Pi's touchscreen driver") > Fixes: 3b8ddff780b7 ("input: raspberrypi-ts: Release firmware handle when not needed") > Signed-off-by: Miaoqian Lin Applied, thank you. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel