From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrew Davis <afd@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: 8250_exar: Add support for USR298x PCI Modems
Date: Fri, 14 Apr 2023 20:10:33 +0300 [thread overview]
Message-ID: <ZDmJCa4I5EA9GLMm@smile.fi.intel.com> (raw)
In-Reply-To: <20230413214421.6251-2-afd@ti.com>
On Thu, Apr 13, 2023 at 04:44:21PM -0500, Andrew Davis wrote:
> Possibly the last PCI controller-based (i.e. not a soft/winmodem)
> dial-up modem one can still buy.
>
> Looks to have a stock XR17C154 PCI UART chip for communication, but for
> some reason when provisioning the PCI IDs they swapped the vendor and
> subvendor IDs. Otherwise this card would have worked out of the box.
>
> Searching online, some folks seem to not have this issue and others do,
> so it is possible only some batches of cards have this error.
>
> Create a new macro to handle the switched IDs and add support here.
Yeah, and here you just going to support the schema before your patch 1.
For this patch
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-04-14 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 21:44 [PATCH 1/2] serial: 8250_exar: Use PCI_DEVICE_DATA macro directly Andrew Davis
2023-04-13 21:44 ` [PATCH 2/2] serial: 8250_exar: Add support for USR298x PCI Modems Andrew Davis
2023-04-14 17:10 ` Andy Shevchenko [this message]
2023-04-20 11:38 ` Greg Kroah-Hartman
2023-04-20 15:56 ` Andrew Davis
2023-04-14 17:07 ` [PATCH 1/2] serial: 8250_exar: Use PCI_DEVICE_DATA macro directly Andy Shevchenko
2023-04-14 17:20 ` Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDmJCa4I5EA9GLMm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=afd@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.