From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20296C77B61 for ; Mon, 1 May 2023 16:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229861AbjEAQZH (ORCPT ); Mon, 1 May 2023 12:25:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbjEAQZG (ORCPT ); Mon, 1 May 2023 12:25:06 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F27F10C2; Mon, 1 May 2023 09:25:05 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-63b50a02bffso1956578b3a.2; Mon, 01 May 2023 09:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682958305; x=1685550305; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Hi2i6+2A7Vme+8Bw6/DbpVhur6f5/wfyKbNa3KD3XxY=; b=gKLjxs75WmlwBqGSSx/wYqqAvwTtUA4KSx3Q+z9o2JPteLVSk0sM2ydoaJwub4ui22 SOQj3Hr/OBBQGZiKcaY/tkwCH1cFVUf95hckaIUMnP/YmYsiIVwVX2r1KXALMrpR9f6b xWcIlT67GL5GhbGiLla+ta52oY22/KZUh4AaEGbasgUQ+MnGDfJFOs7orIE2FBMKq8in Y+acU0h3zwre5KQlbqL5v78b0omZIqoZyteSaQciVGjjztuc6SzQK+VW0Yjtzky7hSUj DbiFe4R94r9EigM9dVoEVAyvn9qDEsNZHzfQvTwKtsiIvVFNF7UpdSRVaEzMkJASM3Y3 q7pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682958305; x=1685550305; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Hi2i6+2A7Vme+8Bw6/DbpVhur6f5/wfyKbNa3KD3XxY=; b=jb8vmoF2oFF8Q4CCGC/etTW8OJbpB5XXeuwLUfm0vhuy3/y/00JEID+XULENuNsJFs Usu/g0qg55ms+O8fWJvllja1LxW9JSrreVZqJwKlnU2IkR0c03a7CDLd8Qglz/WO3UDP q7O8Lk2g07efIZxfsleGzRylcOk1Hh0BAVHL/avfVGA5f3xs/oZzMM9l/uo/NO38h6vs xIENycmeh6ShfQvutsW/4OAPbgR5xEkSFruH+lAjUKjTkd7LAOKkGyPwxnAnbXapnMVX gn2gV27Mmgl2PRYaJ8sdrZhwfkbDaJixEigWmZgvmEsO5Ch2HS4fdNrHQPpcVXQRKykr /0Rg== X-Gm-Message-State: AC+VfDxActLdoNGEO8VKvEFVLnulMYQsl1NQd3i/iIrB1efDWdoBvFhi ysa49BhhhKyt0/Gq9LXL1wI= X-Google-Smtp-Source: ACHHUZ4n14UICtaTafCBlV7ibiarxus3+l8PeLea8hsV8ktohlB6MROy3QkUnTl+1BhcVh+jXYIMxw== X-Received: by 2002:a05:6a00:848:b0:63d:23dc:7760 with SMTP id q8-20020a056a00084800b0063d23dc7760mr21489004pfk.2.1682958304491; Mon, 01 May 2023 09:25:04 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:b6ce:736b:e4f7:adb]) by smtp.gmail.com with ESMTPSA id q5-20020a056a00084500b0062dae524006sm20078819pfk.157.2023.05.01.09.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 09:25:03 -0700 (PDT) Date: Mon, 1 May 2023 09:25:00 -0700 From: Dmitry Torokhov To: Rob Herring Cc: Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Maxime Coquelin , Alexandre Torgue , Lee Jones , Philippe Schenker , Stefan Agner , Marek Vasut , Steffen Trumtrar , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: MFD: Convert STMPE to YAML schema Message-ID: References: <20230426-stmpe-dt-bindings-v2-0-2f85a1fffcda@linaro.org> <20230426-stmpe-dt-bindings-v2-2-2f85a1fffcda@linaro.org> <20230427161633.GA3112472-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230427161633.GA3112472-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Apr 27, 2023 at 11:16:33AM -0500, Rob Herring wrote: > On Wed, Apr 26, 2023 at 01:21:39PM +0200, Linus Walleij wrote: > > This converts the STMPE MFD device tree bindings to the YAML > > schema. > > > > Reference the existing schema for the ADC, just define the > > other subnode schemas directly in the MFD schema. > > > > Add two examples so we have examples covering both the simple > > GPIO expander and the more complex with ADC and touchscreen. > > > > Some in-tree users do not follow the naming conventions for nodes > > so these DTS files need to be augmented to use proper node names > > like "adc", "pwm", "gpio", "keyboard-controller" etc before the > > bindings take effect on them. > > > > Signed-off-by: Linus Walleij > > --- > > ChangeLog v1->v2: > > - Split off the GPIO bindings to their own schema, as the old > > bindings didn't even have any GPIO bindings. Put the GPIO > > schema before this schema so we can use GPIO in the examples. > > - Drop nodename and pattern as STMPE is not a generic name. > > - Add maxItems to the resets. > > - Make wakeup-source just :true, as it is a generic property. > > - Move unevaluatedProperties for subnodes right before properties > > as requested. > > - Name devices "port-expander" in the examples. > > - Use lowercase hex in line init. > > --- > > .../devicetree/bindings/input/stmpe-keypad.txt | 41 --- > > .../bindings/input/touchscreen/stmpe.txt | 108 -------- Since Rob is happy with the bindings, for the input bits: Acked-by: Dmitry Torokhov Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35090C77B7C for ; Mon, 1 May 2023 16:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Msgan622PZ3c6OjhQktntmB2tvYREVTJXEs9/e/I9sc=; b=lWQiXMLCrBYM8A kI/AH3g1UPShV5m9Gx4NvtjVXwrxlMeJWBWh3m5Qs8bayxGG15O16fTupBp+NL8By6rVEzF9go9Y0 JktrVKg2WL2alcEgKRFqN5AS30P2tXb+mhc+zizMJP0JQTTz756UEj53nJ8w+wMUkaeIf1h12wJsn 7kCyhQgMH+PSn2BkVgWfzaii6gp1ofpvLb3dEHoWDOEEnw5G81R9Ic52fCX3rgR1GGx6T/uw0/ELT DqW+mTUfDmk2R9q1loZFsihT1amfv390RbTFy2xfOldmUaWjV0/je84qbhfiMQoSOGAv7LXK4uvnd sos7aRctcCQXzPcPomnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ptWKr-00GJDK-38; Mon, 01 May 2023 16:25:09 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ptWKo-00GJCl-2C for linux-arm-kernel@lists.infradead.org; Mon, 01 May 2023 16:25:08 +0000 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-63b57c49c4cso1950510b3a.3 for ; Mon, 01 May 2023 09:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682958305; x=1685550305; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Hi2i6+2A7Vme+8Bw6/DbpVhur6f5/wfyKbNa3KD3XxY=; b=gKLjxs75WmlwBqGSSx/wYqqAvwTtUA4KSx3Q+z9o2JPteLVSk0sM2ydoaJwub4ui22 SOQj3Hr/OBBQGZiKcaY/tkwCH1cFVUf95hckaIUMnP/YmYsiIVwVX2r1KXALMrpR9f6b xWcIlT67GL5GhbGiLla+ta52oY22/KZUh4AaEGbasgUQ+MnGDfJFOs7orIE2FBMKq8in Y+acU0h3zwre5KQlbqL5v78b0omZIqoZyteSaQciVGjjztuc6SzQK+VW0Yjtzky7hSUj DbiFe4R94r9EigM9dVoEVAyvn9qDEsNZHzfQvTwKtsiIvVFNF7UpdSRVaEzMkJASM3Y3 q7pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682958305; x=1685550305; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Hi2i6+2A7Vme+8Bw6/DbpVhur6f5/wfyKbNa3KD3XxY=; b=Du/0X5Ka953Jpp4m/NPhoxvo3q1oLMf+BK7IGxC0ks7OGISpDnLvN5TvVp8ni19Hgb YKMp2lRHryQdRjUiqnWAPUNbOAI5fe/Dkz8XBVuppOJRboRtzpDkkZ86A+4CR6quomE+ lUuj5XJ0vm5cDUqWLNeUYshvt/2/MWo+YAFj5/tNhAwPbejGSzbiYBxf7ex72o9V0IbO xgHah9hp2ZN3HHU8tdCd8l3nZ+HOiK8UKf502QrZf19BfaIK/wBOb4MVVdx6aMw0KE+Q MliBcV8nvXQqut+c+Uhdntnt7Lupo3KVG5gU9FpSgdbjTPDvHI2Kp1xpBqGe1MYKkXcH VThA== X-Gm-Message-State: AC+VfDyEeT6cW2S7fpkx0BGAsihu2VeZF9xgfMAYDKsEhZ09G0Thabj1 45H4BpMhGURFlRu0CBMBSqY= X-Google-Smtp-Source: ACHHUZ4n14UICtaTafCBlV7ibiarxus3+l8PeLea8hsV8ktohlB6MROy3QkUnTl+1BhcVh+jXYIMxw== X-Received: by 2002:a05:6a00:848:b0:63d:23dc:7760 with SMTP id q8-20020a056a00084800b0063d23dc7760mr21489004pfk.2.1682958304491; Mon, 01 May 2023 09:25:04 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:b6ce:736b:e4f7:adb]) by smtp.gmail.com with ESMTPSA id q5-20020a056a00084500b0062dae524006sm20078819pfk.157.2023.05.01.09.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 09:25:03 -0700 (PDT) Date: Mon, 1 May 2023 09:25:00 -0700 From: Dmitry Torokhov To: Rob Herring Cc: Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Maxime Coquelin , Alexandre Torgue , Lee Jones , Philippe Schenker , Stefan Agner , Marek Vasut , Steffen Trumtrar , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: MFD: Convert STMPE to YAML schema Message-ID: References: <20230426-stmpe-dt-bindings-v2-0-2f85a1fffcda@linaro.org> <20230426-stmpe-dt-bindings-v2-2-2f85a1fffcda@linaro.org> <20230427161633.GA3112472-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230427161633.GA3112472-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230501_092506_745153_9884B3F3 X-CRM114-Status: GOOD ( 21.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 27, 2023 at 11:16:33AM -0500, Rob Herring wrote: > On Wed, Apr 26, 2023 at 01:21:39PM +0200, Linus Walleij wrote: > > This converts the STMPE MFD device tree bindings to the YAML > > schema. > > > > Reference the existing schema for the ADC, just define the > > other subnode schemas directly in the MFD schema. > > > > Add two examples so we have examples covering both the simple > > GPIO expander and the more complex with ADC and touchscreen. > > > > Some in-tree users do not follow the naming conventions for nodes > > so these DTS files need to be augmented to use proper node names > > like "adc", "pwm", "gpio", "keyboard-controller" etc before the > > bindings take effect on them. > > > > Signed-off-by: Linus Walleij > > --- > > ChangeLog v1->v2: > > - Split off the GPIO bindings to their own schema, as the old > > bindings didn't even have any GPIO bindings. Put the GPIO > > schema before this schema so we can use GPIO in the examples. > > - Drop nodename and pattern as STMPE is not a generic name. > > - Add maxItems to the resets. > > - Make wakeup-source just :true, as it is a generic property. > > - Move unevaluatedProperties for subnodes right before properties > > as requested. > > - Name devices "port-expander" in the examples. > > - Use lowercase hex in line init. > > --- > > .../devicetree/bindings/input/stmpe-keypad.txt | 41 --- > > .../bindings/input/touchscreen/stmpe.txt | 108 -------- Since Rob is happy with the bindings, for the input bits: Acked-by: Dmitry Torokhov Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel