From: Anup Sharma <anupnewsmail@gmail.com>
To: zbr@ioremap.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] drivers: w1: slaves: Drop unnecessary explicit casting
Date: Thu, 20 Apr 2023 05:51:33 +0530 [thread overview]
Message-ID: <ZECFjQMLwnoYPMeL@yoga> (raw)
Provide correct specifiers while printing error logs to discard the use
of unnecessary explicit casting.
Signed-off-by: Anup Sharma <anupnewsmail@gmail.com>
---
drivers/w1/slaves/w1_ds2433.c | 6 +++---
drivers/w1/slaves/w1_ds28e04.c | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/w1/slaves/w1_ds2433.c b/drivers/w1/slaves/w1_ds2433.c
index 0f72df15a024..ba441d42b0b0 100644
--- a/drivers/w1/slaves/w1_ds2433.c
+++ b/drivers/w1/slaves/w1_ds2433.c
@@ -213,15 +213,15 @@ static ssize_t eeprom_write(struct file *filp, struct kobject *kobj,
#ifdef CONFIG_W1_SLAVE_DS2433_CRC
/* can only write full blocks in cached mode */
if ((off & W1_PAGE_MASK) || (count & W1_PAGE_MASK)) {
- dev_err(&sl->dev, "invalid offset/count off=%d cnt=%zd\n",
- (int)off, count);
+ dev_err(&sl->dev, "invalid offset/count off=%pe cnt=%zd\n",
+ off, count);
return -EINVAL;
}
/* make sure the block CRCs are valid */
for (idx = 0; idx < count; idx += W1_PAGE_SIZE) {
if (crc16(CRC16_INIT, &buf[idx], W1_PAGE_SIZE) != CRC16_VALID) {
- dev_err(&sl->dev, "bad CRC at offset %d\n", (int)off);
+ dev_err(&sl->dev, "bad CRC at offset %pe\n", off);
return -EINVAL;
}
}
diff --git a/drivers/w1/slaves/w1_ds28e04.c b/drivers/w1/slaves/w1_ds28e04.c
index 6cef6e2edb89..6edfe6a4600a 100644
--- a/drivers/w1/slaves/w1_ds28e04.c
+++ b/drivers/w1/slaves/w1_ds28e04.c
@@ -234,8 +234,8 @@ static ssize_t eeprom_write(struct file *filp, struct kobject *kobj,
if (w1_enable_crccheck) {
/* can only write full blocks in cached mode */
if ((off & W1_PAGE_MASK) || (count & W1_PAGE_MASK)) {
- dev_err(&sl->dev, "invalid offset/count off=%d cnt=%zd\n",
- (int)off, count);
+ dev_err(&sl->dev, "invalid offset/count off=%pe cnt=%zd\n",
+ off, count);
return -EINVAL;
}
@@ -243,8 +243,8 @@ static ssize_t eeprom_write(struct file *filp, struct kobject *kobj,
for (idx = 0; idx < count; idx += W1_PAGE_SIZE) {
if (crc16(CRC16_INIT, &buf[idx], W1_PAGE_SIZE)
!= CRC16_VALID) {
- dev_err(&sl->dev, "bad CRC at offset %d\n",
- (int)off);
+ dev_err(&sl->dev, "bad CRC at offset %pe\n",
+ off);
return -EINVAL;
}
}
--
2.34.1
next reply other threads:[~2023-04-20 0:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 0:21 Anup Sharma [this message]
2023-04-20 2:35 ` [PATCH] drivers: w1: slaves: Drop unnecessary explicit casting kernel test robot
2023-04-20 6:29 ` kernel test robot
2023-04-23 13:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZECFjQMLwnoYPMeL@yoga \
--to=anupnewsmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.