From: Simon Horman <simon.horman@corigine.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Laight <David.Laight@aculab.com>,
'Louis Peens' <louis.peens@corigine.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"oss-drivers@corigine.com" <oss-drivers@corigine.com>
Subject: Re: [PATCH net v2] nfp: correct number of MSI vectors requests returned
Date: Thu, 20 Apr 2023 09:25:05 +0200 [thread overview]
Message-ID: <ZEDo0RrtX5okUTN2@corigine.com> (raw)
In-Reply-To: <20230419183409.1fba81b7@kernel.org>
On Wed, Apr 19, 2023 at 06:34:09PM -0700, Jakub Kicinski wrote:
> On Wed, 19 Apr 2023 15:37:57 +0000 David Laight wrote:
> > > Before the referenced commit, if fewer interrupts are supported by
> > > hardware than requested, then pci_msix_vec_count() returned the
> > > former. However, after the referenced commit, an error is returned
> > > for this condition. This causes a regression in the NFP driver
> > > preventing probe from completing.
> >
> > I believe the relevant change to the msix vector allocation
> > function has been reverted.
> > (Or at least, the over-zealous check of nvec removed.)
> >
> > So this change to bound the number of interrupts
> > isn't needed.
>
> Great, thanks, I was about to ask!
Likewise, thanks.
We'll look into this.
prev parent reply other threads:[~2023-04-20 7:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 8:15 [PATCH net v2] nfp: correct number of MSI vectors requests returned Louis Peens
2023-04-19 15:37 ` David Laight
2023-04-20 1:34 ` Jakub Kicinski
2023-04-20 7:25 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEDo0RrtX5okUTN2@corigine.com \
--to=simon.horman@corigine.com \
--cc=David.Laight@aculab.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.