From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [RFC PATCH] docs: sound: kernel-api: writing-an-alsa-driver.rst: add FIXMEs
Date: Thu, 20 Apr 2023 15:44:50 +0200 [thread overview]
Message-ID: <ZEFB0r20odpxH6pR@ugly> (raw)
In-Reply-To: <87wn26u32c.wl-tiwai@suse.de>
On Thu, Apr 20, 2023 at 02:54:19PM +0200, Takashi Iwai wrote:
>On Thu, 20 Apr 2023 14:47:11 +0200, Oswald Buddenhagen wrote:
>> On Thu, Apr 06, 2023 at 08:42:27AM +0200, Takashi Iwai wrote:
>> > On Wed, 05 Apr 2023 22:12:20 +0200, Oswald Buddenhagen wrote:
>> >> The ``name`` is the name identifier string. Since ALSA 0.9.x, the
>> >> control name is very important, because its role is classified from
>> >> its name.
>> >> +// This is a questionable design, IMO. Why user-space heuristics when
>> >> +// the driver could set the roles/capabilities? This would avoid
>> >> +// problems like the Tone Control sliders (unlike the switch?!) being
>> >> +// misclassified as applying also to capture.
>> >
>> > Why this has to be discussed here and now...?
>> >
>> why not?
>
>Because it is the already defined rule, and you're complaining the
>documentation. You are free to start a new discussion, but not it
>shouldn't be along with the documentation patch at all.
>
this is a "various questions about the documentation" patch/thread. i
can't think of a better place to discuss/document design choices.
>> > It's the thing that was *defined* over two decades ago.
>> >
>> that may be so, but this doesn't explain anything.
>> it's a somewhat surprising choice, and it does in fact sometimes cause
>> problems. so at least it should be thoroughly explained.
>
>Again, you're barking at a wrong place. The whole control name ruling
>is explained in another document; there is another document covering
>control name rules.
>
there is the control-names.rst document.
if you agree, i'd actually move the entire "Control Names" section into
it, to avoid redundancy.
but none of that explains the design choice.
two questions require an answer, imo: a) why was is done this way and b)
do you still consider it the right choice?
regards
next prev parent reply other threads:[~2023-04-20 13:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 20:12 [RFC PATCH] docs: sound: kernel-api: writing-an-alsa-driver.rst: add FIXMEs Oswald Buddenhagen
2023-04-06 6:42 ` Takashi Iwai
2023-04-20 12:47 ` Oswald Buddenhagen
2023-04-20 12:54 ` Takashi Iwai
2023-04-20 13:44 ` Oswald Buddenhagen [this message]
2023-04-20 14:27 ` Takashi Iwai
2023-04-20 16:18 ` Oswald Buddenhagen
2023-04-21 8:55 ` Takashi Iwai
2023-04-21 9:11 ` Oswald Buddenhagen
2023-04-21 9:14 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEFB0r20odpxH6pR@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.