From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27C4C320A for ; Thu, 20 Apr 2023 20:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682024030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8InUreRUNhx4YcihT8dj307g5hljV9sg88uJ8MQywSg=; b=Is9xMm0751QTMPrsl2yqHXzBKPXinPbD1M/XOArFW2TQIIldymJq1qhnnKUUkWjAhhr4YO vxvHtm51tpm+vXV9UgjH2IZxOD8c5Oeh5CF9BBcmCcNeFtSNwv9f9M/bMEkiIY+Onh7C+c hz8Fgp4K8lqY0zf8hSV44zxJ0MyDQns= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-T-xtXvIqM7uNKtg8W-Bmrg-1; Thu, 20 Apr 2023 16:53:48 -0400 X-MC-Unique: T-xtXvIqM7uNKtg8W-Bmrg-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-3ef3116d1dcso3211611cf.1 for ; Thu, 20 Apr 2023 13:53:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682024028; x=1684616028; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8InUreRUNhx4YcihT8dj307g5hljV9sg88uJ8MQywSg=; b=Yw1P0cHZ1N3gWtcqOvbE91ptkzFaEjVltkUHXH822gGwKeKT4Lw9jKHpeuBzJkFU8N ni6xhr2CQ6pGtiWIKHQmVFU8zlwdPOISFmJfFx5D9MAsVuM3Jjs4cY1g4Ws6qeYNnzQc bqk+U/yxFpwVwAxQhOnIVWNLcIrsLXgeRALBOsfmyMMBkBXR+h4Cex6LSG+OTxBmmOsf 5vQPn4S91BoFficHqZJADWO6HXp76N5OIBkRJ2retAnmHVWzE5yPAFUGfcaey5kV9HgC YThuLYE9gy9NG4XOcsnbMeQpQh70u4N7OwziJu+qidgzq9ZSLOUH6ARJIyTfX6yCBN5D Sxzg== X-Gm-Message-State: AAQBX9dZ9Rn0HSiBpd+5uix29N1R8/S0KlIUo3elAVzZGPEVlNcJbkvd StKfjd/doYKAb9nYqLwiDiS6sjJ7cnjNA2u9F9akfoXSumsnYXN2Ys8QdrPaGS9KQq4bjyvKIuq 0bzfjL1fpTNl2IbLm X-Received: by 2002:a05:6214:5195:b0:5de:5da:b873 with SMTP id kl21-20020a056214519500b005de05dab873mr4390815qvb.3.1682024028184; Thu, 20 Apr 2023 13:53:48 -0700 (PDT) X-Google-Smtp-Source: AKy350a6N61cy4ViOMnJA6wPwFePU1JTwO4kJEKCYCQbAdeBQMKAcdu1S9n5lWu/p0VA+/q1z2i4pg== X-Received: by 2002:a05:6214:5195:b0:5de:5da:b873 with SMTP id kl21-20020a056214519500b005de05dab873mr4390802qvb.3.1682024027951; Thu, 20 Apr 2023 13:53:47 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id dp1-20020a05620a2b4100b0074ded6ad058sm694198qkb.129.2023.04.20.13.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 13:53:47 -0700 (PDT) Date: Thu, 20 Apr 2023 16:53:46 -0400 From: Peter Xu To: Anish Moorthy Cc: pbonzini@redhat.com, maz@kernel.org, oliver.upton@linux.dev, seanjc@google.com, jthoughton@google.com, bgardon@google.com, dmatlack@google.com, ricarkol@google.com, axelrasmussen@google.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v3 09/22] KVM: Annotate -EFAULTs from kvm_vcpu_map() Message-ID: References: <20230412213510.1220557-1-amoorthy@google.com> <20230412213510.1220557-10-amoorthy@google.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20230412213510.1220557-10-amoorthy@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On Wed, Apr 12, 2023 at 09:34:57PM +0000, Anish Moorthy wrote: > Implement KVM_CAP_MEMORY_FAULT_INFO for efaults generated by > kvm_vcpu_map(). > > Signed-off-by: Anish Moorthy > --- > virt/kvm/kvm_main.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 572adba9ad8ed..f3be5aa49829a 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2843,8 +2843,10 @@ int kvm_vcpu_map(struct kvm_vcpu *vcpu, gfn_t gfn, struct kvm_host_map *map) > #endif > } > > - if (!hva) > + if (!hva) { > + kvm_populate_efault_info(vcpu, gfn * PAGE_SIZE, PAGE_SIZE); > return -EFAULT; > + } > > map->page = page; > map->hva = hva; Totally not familiar with nested, just a pure question on whether all the kvm_vcpu_map() callers will be prepared to receive this -EFAULT yet? I quickly went over the later patches but I didn't find a full solution yet, but maybe I missed something. Thanks, -- Peter Xu