From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EEB7C7618E for ; Fri, 21 Apr 2023 18:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5xhs85aQkTRgCJRjbjY7O4iRGRT2kG1Og2r2mzLD7Ic=; b=OBopmrf01SXmLh5x6A4/powJQV PQOLYpd83thyXWcCT7zc2zOutAc+CsVcYslhKwHVcZI//k7WDHdUx9sCkTA2XiCYy1uIVrJ1PFc1r 7I9rFoPglXOBD0JJnuMXQ/fg/q0qfhe/+f5xiqmbiPN6pfma7Jg3fYzfbZOyDeqDnSeJ0pvsckWm5 QYsRv20JsT1iYICn6UhZ/kSoxcdYoej+17k8LsSTUa9Z1JGwWwpJuFXhDgxU4JNRzmOAPkd7M0wRZ pcATASEgnBeMV2mnaAbGFiI5Ylqnl4q+YjhN0KT9SgitS1ZpZgw4hN2NghZtxu9qjpnMxEe2XNcWI PowsQQfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppvZw-00BdUV-1b; Fri, 21 Apr 2023 18:33:52 +0000 Received: from fudo.makrotopia.org ([2a07:2ec0:3002::71]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppvZq-00BdSo-0Y; Fri, 21 Apr 2023 18:33:50 +0000 Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1ppvZB-0002bf-2a; Fri, 21 Apr 2023 20:33:06 +0200 Date: Fri, 21 Apr 2023 19:32:58 +0100 From: Daniel Golle To: arinc9.unal@gmail.com Subject: Re: [RFC PATCH net-next 19/22] net: dsa: mt7530: set interrupt register only for MT7530 Message-ID: References: <20230421143648.87889-1-arinc.unal@arinc9.com> <20230421143648.87889-20-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230421143648.87889-20-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230421_113346_209450_9FF9384E X-CRM114-Status: GOOD ( 16.46 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Eric Dumazet , erkin.bozoglu@xeront.com, Florian Fainelli , Russell King , Richard van Schagen , Jakub Kicinski , Paolo Abeni , Landen Chao , Richard van Schagen , Sean Wang , DENG Qingfang , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Oltean , "David S. Miller" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Apr 21, 2023 at 05:36:45PM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > Setting this register related to interrupts is only needed for the MT7530 > switch. Make an exclusive check to ensure this. > > Signed-off-by: Arınç ÜNAL Acked-by: Daniel Golle Tested-by: Daniel Golle (on MT7988 which is the relevant hardware regarding this change, interrupts still work fine) > --- > drivers/net/dsa/mt7530.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index a66a762cb5db..ac1e3c58aaac 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -2034,7 +2034,7 @@ mt7530_setup_irq(struct mt7530_priv *priv) > } > > /* This register must be set for MT7530 to properly fire interrupts */ > - if (priv->id != ID_MT7531) > + if (priv->id == ID_MT7530 || priv->id == ID_MT7621) > mt7530_set(priv, MT7530_TOP_SIG_CTRL, TOP_SIG_CTRL_NORMAL); > > ret = request_threaded_irq(priv->irq, NULL, mt7530_irq_thread_fn, > -- > 2.37.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 108E1C77B76 for ; Fri, 21 Apr 2023 18:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FbR3+zLAVYCUuGGeIlwqES7NbqyxNokaUkObWBQMAbQ=; b=upkJMDveISIEYP I/ZWsrTkG8WzJkIJZAGVwS3rXsrixmQCS9Nfww6Cn/aeU0pJiEFkJPvml22B5mgIDZR5bHj20GDaG dlIcKSeDQNTXe0ZfMr2MAtkVxlORnBUIRL0QMQ13J1BVetydpsS0zjb78ldjoQFc+XP7gm8eW7Srq UOjGOIngpZX+P2alK7JMPTiLzVLfYO2Nz237cXyYfd8tEKeC/tnRO7gkjSrFtUtt8GT6J4dPgMLLf 3SDnWN4EPkBobZDuFyvfZBpEYn4YWLeM8YFNyQA9beppMtBNh2HqdAq9i0hBFZAznUKFADnh7BTZb +nAZN0u+KzbzFziI971Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppvZv-00BdUJ-24; Fri, 21 Apr 2023 18:33:51 +0000 Received: from fudo.makrotopia.org ([2a07:2ec0:3002::71]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppvZq-00BdSo-0Y; Fri, 21 Apr 2023 18:33:50 +0000 Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1ppvZB-0002bf-2a; Fri, 21 Apr 2023 20:33:06 +0200 Date: Fri, 21 Apr 2023 19:32:58 +0100 From: Daniel Golle To: arinc9.unal@gmail.com Cc: Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Richard van Schagen , Richard van Schagen , Frank Wunderlich , erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [RFC PATCH net-next 19/22] net: dsa: mt7530: set interrupt register only for MT7530 Message-ID: References: <20230421143648.87889-1-arinc.unal@arinc9.com> <20230421143648.87889-20-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230421143648.87889-20-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230421_113346_209450_9FF9384E X-CRM114-Status: GOOD ( 16.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBcHIgMjEsIDIwMjMgYXQgMDU6MzY6NDVQTSArMDMwMCwgYXJpbmM5LnVuYWxAZ21h aWwuY29tIHdyb3RlOgo+IEZyb206IEFyxLFuw6cgw5xOQUwgPGFyaW5jLnVuYWxAYXJpbmM5LmNv bT4KPiAKPiBTZXR0aW5nIHRoaXMgcmVnaXN0ZXIgcmVsYXRlZCB0byBpbnRlcnJ1cHRzIGlzIG9u bHkgbmVlZGVkIGZvciB0aGUgTVQ3NTMwCj4gc3dpdGNoLiBNYWtlIGFuIGV4Y2x1c2l2ZSBjaGVj ayB0byBlbnN1cmUgdGhpcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBcsSxbsOnIMOcTkFMIDxhcmlu Yy51bmFsQGFyaW5jOS5jb20+CgpBY2tlZC1ieTogRGFuaWVsIEdvbGxlIDxkYW5pZWxAbWFrcm90 b3BpYS5vcmc+ClRlc3RlZC1ieTogRGFuaWVsIEdvbGxlIDxkYW5pZWxAbWFrcm90b3BpYS5vcmc+ CihvbiBNVDc5ODggd2hpY2ggaXMgdGhlIHJlbGV2YW50IGhhcmR3YXJlIHJlZ2FyZGluZyB0aGlz IGNoYW5nZSwKaW50ZXJydXB0cyBzdGlsbCB3b3JrIGZpbmUpCgoKPiAtLS0KPiAgZHJpdmVycy9u ZXQvZHNhL210NzUzMC5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks IDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZHNhL210NzUzMC5j IGIvZHJpdmVycy9uZXQvZHNhL210NzUzMC5jCj4gaW5kZXggYTY2YTc2MmNiNWRiLi5hYzFlM2M1 OGFhYWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQvZHNhL210NzUzMC5jCj4gKysrIGIvZHJp dmVycy9uZXQvZHNhL210NzUzMC5jCj4gQEAgLTIwMzQsNyArMjAzNCw3IEBAIG10NzUzMF9zZXR1 cF9pcnEoc3RydWN0IG10NzUzMF9wcml2ICpwcml2KQo+ICAJfQo+ICAKPiAgCS8qIFRoaXMgcmVn aXN0ZXIgbXVzdCBiZSBzZXQgZm9yIE1UNzUzMCB0byBwcm9wZXJseSBmaXJlIGludGVycnVwdHMg Ki8KPiAtCWlmIChwcml2LT5pZCAhPSBJRF9NVDc1MzEpCj4gKwlpZiAocHJpdi0+aWQgPT0gSURf TVQ3NTMwIHx8IHByaXYtPmlkID09IElEX01UNzYyMSkKPiAgCQltdDc1MzBfc2V0KHByaXYsIE1U NzUzMF9UT1BfU0lHX0NUUkwsIFRPUF9TSUdfQ1RSTF9OT1JNQUwpOwo+ICAKPiAgCXJldCA9IHJl cXVlc3RfdGhyZWFkZWRfaXJxKHByaXYtPmlycSwgTlVMTCwgbXQ3NTMwX2lycV90aHJlYWRfZm4s Cj4gLS0gCj4gMi4zNy4yCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96893C7618E for ; Fri, 21 Apr 2023 18:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233252AbjDUSdp (ORCPT ); Fri, 21 Apr 2023 14:33:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233227AbjDUSdn (ORCPT ); Fri, 21 Apr 2023 14:33:43 -0400 Received: from fudo.makrotopia.org (fudo.makrotopia.org [IPv6:2a07:2ec0:3002::71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A8C81FF7; Fri, 21 Apr 2023 11:33:33 -0700 (PDT) Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1ppvZB-0002bf-2a; Fri, 21 Apr 2023 20:33:06 +0200 Date: Fri, 21 Apr 2023 19:32:58 +0100 From: Daniel Golle To: arinc9.unal@gmail.com Cc: Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Richard van Schagen , Richard van Schagen , Frank Wunderlich , erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [RFC PATCH net-next 19/22] net: dsa: mt7530: set interrupt register only for MT7530 Message-ID: References: <20230421143648.87889-1-arinc.unal@arinc9.com> <20230421143648.87889-20-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230421143648.87889-20-arinc.unal@arinc9.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2023 at 05:36:45PM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > Setting this register related to interrupts is only needed for the MT7530 > switch. Make an exclusive check to ensure this. > > Signed-off-by: Arınç ÜNAL Acked-by: Daniel Golle Tested-by: Daniel Golle (on MT7988 which is the relevant hardware regarding this change, interrupts still work fine) > --- > drivers/net/dsa/mt7530.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index a66a762cb5db..ac1e3c58aaac 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -2034,7 +2034,7 @@ mt7530_setup_irq(struct mt7530_priv *priv) > } > > /* This register must be set for MT7530 to properly fire interrupts */ > - if (priv->id != ID_MT7531) > + if (priv->id == ID_MT7530 || priv->id == ID_MT7621) > mt7530_set(priv, MT7530_TOP_SIG_CTRL, TOP_SIG_CTRL_NORMAL); > > ret = request_threaded_irq(priv->irq, NULL, mt7530_irq_thread_fn, > -- > 2.37.2 >