From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH] MIPS: uprobes: Restore thread.trap_nr
Date: Sun, 23 Apr 2023 10:08:37 +0700 [thread overview]
Message-ID: <ZEShNUil0gsVlrDo@debian.me> (raw)
In-Reply-To: <1682213883-3654-1-git-send-email-yangtiezhu@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
On Sun, Apr 23, 2023 at 09:38:03AM +0800, Tiezhu Yang wrote:
> thread.trap_nr is saved in arch_uprobe_pre_xol(), it should be restored
> in arch_uprobe_{post,abort}_xol() accordingly, actually it was only done
> in the post function, just do it in the abort function too, this change
> is similar with x86 and powerpc.
I'm confused (please fix up grammar, spelling, and punctuation). Can you
explain why thread.trap_nr should be restored somewhere else? Also, what
x86/powerpc changes as reference?
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-04-23 3:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 1:38 [PATCH] MIPS: uprobes: Restore thread.trap_nr Tiezhu Yang
2023-04-23 3:08 ` Bagas Sanjaya [this message]
2023-04-23 10:39 ` Tiezhu Yang
2023-04-24 11:07 ` Oleg Nesterov
2023-04-24 11:32 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEShNUil0gsVlrDo@debian.me \
--to=bagasdotme@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.