From: Mehdi Djait <mehdi.djait.k@gmail.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: jic23@kernel.org, krzysztof.kozlowski+dt@linaro.org,
andriy.shevchenko@linux.intel.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/5] iio: accel: kionix-kx022a: Add a function to retrieve number of bytes in buffer
Date: Mon, 24 Apr 2023 00:06:53 +0200 [thread overview]
Message-ID: <ZEWr/RHDJZZXknSJ@carbian> (raw)
In-Reply-To: <93b19237-3afd-461f-bdb3-f2cd09cadd9a@gmail.com>
Hi Matti,
On Fri, Apr 21, 2023 at 09:14:10AM +0300, Matti Vaittinen wrote:
> Hi Mehdi,
>
> Thanks for the v2!
>
> On 4/20/23 23:22, Mehdi Djait wrote:
> > Since Kionix accelerometers use various numbers of bits to report data, a
> > device-specific function is required.
>
> I think this is the right approach. Thanks for adding this device-specific
> function.
>
> > Move the driver's private data to the header file to support the new function.
>
> Hmm. Why this move is necessary? I didn't immediately spot this struct being
> used outside this C-file. I'd rather saw the struct in C-file if possible.
My bad, I will move it back
--
Kind Regards
Mehdi Djait
next prev parent reply other threads:[~2023-04-23 22:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 20:22 [PATCH v2 0/5] iio: accel: Add support for Kionix/ROHM KX132-1211 accelerometer Mehdi Djait
2023-04-20 20:22 ` [PATCH v2 1/5] dt-bindings: iio: Add " Mehdi Djait
2023-04-21 3:36 ` Matti Vaittinen
2023-04-21 8:12 ` Krzysztof Kozlowski
2023-04-20 20:22 ` [PATCH v2 2/5] iio: accel: kionix-kx022a: Warn on failed matches and assume compatibility Mehdi Djait
2023-04-21 3:44 ` Matti Vaittinen
2023-04-22 17:26 ` Jonathan Cameron
2023-04-22 17:28 ` Jonathan Cameron
2023-04-23 20:59 ` Mehdi Djait
2023-04-20 20:22 ` [PATCH v2 3/5] iio: accel: kionix-kx022a: Refactor driver and add chip_info structure Mehdi Djait
2023-04-21 6:19 ` Matti Vaittinen
2023-04-22 17:32 ` Jonathan Cameron
2023-04-23 21:01 ` Mehdi Djait
2023-04-20 20:22 ` [PATCH v2 4/5] iio: accel: kionix-kx022a: Add a function to retrieve number of bytes in buffer Mehdi Djait
2023-04-21 6:14 ` Matti Vaittinen
2023-04-22 17:36 ` Jonathan Cameron
2023-04-22 17:42 ` Jonathan Cameron
2023-04-23 22:06 ` Mehdi Djait [this message]
2023-04-22 17:46 ` Jonathan Cameron
2023-04-23 22:05 ` Mehdi Djait
2023-04-20 20:22 ` [PATCH v2 5/5] iio: accel: Add support for Kionix/ROHM KX132-1211 accelerometer Mehdi Djait
2023-04-21 23:19 ` kernel test robot
2023-04-22 16:09 ` Andy Shevchenko
2023-04-23 20:56 ` Mehdi Djait
2023-04-24 14:56 ` Mehdi Djait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEWr/RHDJZZXknSJ@carbian \
--to=mehdi.djait.k@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.