From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Zhigang Shi <Zhigang.Shi@liteon.com>,
Shreeya Patel <shreeya.patel@collabora.com>,
Paul Gazzillo <paul@pgazz.com>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] iio: light: ROHM BU27008 color sensor
Date: Mon, 24 Apr 2023 18:22:11 +0300 [thread overview]
Message-ID: <ZEaeoxdWTknLz7lQ@smile.fi.intel.com> (raw)
In-Reply-To: <d51d5e2b3eff65fd86aeb47840db9cd413d96668.1682340947.git.mazziesaccount@gmail.com>
On Mon, Apr 24, 2023 at 04:10:09PM +0300, Matti Vaittinen wrote:
> The ROHM BU27008 is a sensor with 5 photodiodes (red, green, blue, clear
> and IR) with four configurable channels. Red and green being always
> available and two out of the rest three (blue, clear, IR) can be
> selected to be simultaneously measured. Typical application is adjusting
> LCD backlight of TVs, mobile phones and tablet PCs.
>
> Add initial support for the ROHM BU27008 color sensor.
> - raw_read() of RGB and clear channels
> - triggered buffer w/ DRDY interrtupt
...
This...
> +#include <linux/bits.h>
...is guaranteed to be included by this.
> +#include <linux/bitops.h>
...
> +static const struct of_device_id bu27008_of_match[] = {
> + { .compatible = "rohm,bu27008", },
Inner comma is not necessary to have.
> + { }
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-04-24 15:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 13:07 [PATCH v2 0/5] Support ROHM BU27008 RGB sensor Matti Vaittinen
2023-04-24 13:07 ` [PATCH v2 1/5] dt-bindings: iio: light: ROHM BU27008 Matti Vaittinen
2023-04-24 14:00 ` Krzysztof Kozlowski
2023-04-24 13:08 ` [PATCH v2 2/5] iio:trigger: Add simple trigger_validation helper Matti Vaittinen
2023-04-24 15:08 ` Andy Shevchenko
2023-04-25 5:17 ` Matti Vaittinen
2023-04-24 13:08 ` [PATCH v2 3/5] iio: kx022a: Use new iio_validate_own_trigger() Matti Vaittinen
2023-04-24 13:10 ` [PATCH v2 4/5] iio: light: ROHM BU27008 color sensor Matti Vaittinen
2023-04-24 15:22 ` Andy Shevchenko [this message]
2023-04-25 5:24 ` Matti Vaittinen
2023-04-25 13:45 ` Andy Shevchenko
2023-04-25 16:45 ` Andi Shyti
2023-04-26 5:32 ` Matti Vaittinen
2023-04-26 10:12 ` Andi Shyti
2023-04-26 10:19 ` Matti Vaittinen
2023-04-26 12:20 ` Andi Shyti
2023-04-24 13:10 ` [PATCH v2 5/5] MAINTAINERS: Add ROHM BU27008 Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEaeoxdWTknLz7lQ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Zhigang.Shi@liteon.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.osipenko@collabora.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=paul@pgazz.com \
--cc=robh+dt@kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.