All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Liang Yuhang <lihuya@hust.edu.cn>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	hust-os-kernel-patches@googlegroups.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2] usb: dwc3: remove dead code in dwc3_otg_get_irq
Date: Tue, 25 Apr 2023 07:12:15 +0200	[thread overview]
Message-ID: <ZEdhLyEw_x49zZKp@kroah.com> (raw)
In-Reply-To: <20230425015532.13622-1-lihuya@hust.edu.cn>

On Tue, Apr 25, 2023 at 09:55:32AM +0800, Liang Yuhang wrote:
> platform_get_irq() only return non-zero irq number on success, or
> negative error number on failure.
> 
> There is no need to check the return value of platform_get_irq()
> to determine the return value of dwc3_otg_get_irq(), removing
> them to solve this problem.
> 
> Signed-off-by: Liang Yuhang <lihuya@hust.edu.cn>
> 
> ---
> v1 -> v2: change name to real name
> ---
>  drivers/usb/dwc3/drd.c | 5 -----
>  1 file changed, 5 deletions(-)

Why is this a RESEND?  And why is it resent?  You changed something from
v1 to v2, but that does not mean it is a resend.

Note, I STRONGLY encourage people to get experience by working in
drivers/staging/ first, before going out to the rest of the kernel and
dealing with fast-moving subsystems.  Perhaps try that first?

thanks,

greg k-h

      reply	other threads:[~2023-04-25  5:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25  1:55 [PATCH RESEND v2] usb: dwc3: remove dead code in dwc3_otg_get_irq Liang Yuhang
2023-04-25  5:12 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZEdhLyEw_x49zZKp@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=hust-os-kernel-patches@googlegroups.com \
    --cc=lihuya@hust.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.