All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: wangliangzz@126.com
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	qemu-stable@nongnu.org, hreitz@redhat.com, eesposit@redhat.com,
	Wang Liang <wangliangzz@inspur.com>
Subject: Re: [PATCH v2] block/monitor/block-hmp-cmds.c: Fix crash when execute hmp_commit
Date: Tue, 25 Apr 2023 14:09:41 +0200	[thread overview]
Message-ID: <ZEfDBdRE1bxK/L+o@redhat.com> (raw)
In-Reply-To: <20230424103902.45265-1-wangliangzz@126.com>

Am 24.04.2023 um 12:39 hat wangliangzz@126.com geschrieben:
> From: Wang Liang <wangliangzz@inspur.com>
> 
> hmp_commit() calls blk_is_available() from a non-coroutine context (and in
> the main loop). blk_is_available() is a co_wrapper_mixed_bdrv_rdlock
> function, and in the non-coroutine context it calls AIO_WAIT_WHILE(),
> which crashes if the aio_context lock is not taken before.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1615
> Signed-off-by: Wang Liang <wangliangzz@inspur.com>

Thanks, applied to the block branch.

Kevin



      parent reply	other threads:[~2023-04-25 12:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24 10:39 [PATCH v2] block/monitor/block-hmp-cmds.c: Fix crash when execute hmp_commit wangliangzz
2023-04-24 10:51 ` Emanuele Giuseppe Esposito
2023-04-25 12:09 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZEfDBdRE1bxK/L+o@redhat.com \
    --to=kwolf@redhat.com \
    --cc=eesposit@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=wangliangzz@126.com \
    --cc=wangliangzz@inspur.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.