Re: [dm-devel] [PATCH blktests] dm: add a regression test

From: Mike Snitzer <snitzer@kernel.org>
To: Shin'ichiro Kawasaki <shinichiro@fastmail.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
	"yi.zhang@huawei.com" <yi.zhang@huawei.com>,
	"yangerkun@huawei.com" <yangerkun@huawei.com>,
	Joe Thornber <ejt@redhat.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Yu Kuai <yukuai1@huaweicloud.com>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	shinichiro.kawasaki@wdc.com, "yukuai \(C\)" <yukuai3@huawei.com>,
	Li Lingfeng <lilingfeng3@huawei.com>
Subject: Re: [dm-devel] [PATCH blktests] dm: add a regression test
Date: Tue, 25 Apr 2023 13:24:10 -0400	[thread overview]
Message-ID: <ZEgMuvNCud3fNdl4@redhat.com> (raw)
In-Reply-To: <oklvotdaxnncrugr2v7yqadzyfa5vvzrumrfv46vrzowjw3njo@tlvhd4eo5spl>

On Tue, Apr 25 2023 at  8:15P -0400,
Shin'ichiro Kawasaki <shinichiro@fastmail.com> wrote:

> On Apr 25, 2023 / 16:22, Yu Kuai wrote:
> > Hi,
> > 
> > 在 2023/01/12 9:05, Shinichiro Kawasaki 写道:
> > > Hello Yu, thanks for the patch. I think it is good to have this test case to
> > > avoid repeating the same regression. Please find my comments in line.
> > > 
> > > CC+: Mike, dm-devel,
> > > 
> > > Mike, could you take a look in this new test case? It adds "dm" test group to
> > > blktests. If you have thoughts on how to add device-mapper related test cases
> > > to blktests, please share (Or we may be able to discuss later at LSF 2023).
> > 
> > Can we add "dm" test group to blktests? I'll send a new version if we
> > can.
> 
> I suggest to wait for LSF discussion in May, which could be a good chance to
> hear opinions of dm experts. I think your new test case is valuable, so IMO it
> should be added to the new "dm" group, or at least to the existing "block"
> group. Let's decide the target group after LSF.
> 

It's obviously fine to add a new "dm" test group to blktests.

But just so others are aware: more elaborate dm testing is currently
spread across multiple testsuites (e.g. lvm2, cryptsetup, mptest,
device-mapper-test-suite, etc).

There is new effort to port device-mapper-test-suite tests (which use
ruby) to a new python harness currently named "dmtest-python", Joe
Thornber is leading this effort (with the assistance of
ChatGPT.. apparently it has been wonderful in helping Joe glue python
code together to accomplish anything he's needed):
https://github.com/jthornber/dmtest-python

(we've discussed renaming "dmtest-python" to "dmtests")

I've also discussed with Joe the plan to wrap the other disparate
testsuites with DM coverage in terms of the new dmtest-python.
blktests can be made to be one of the testsuites we add support for
(so that all blktests run on various types of DM targets).

Really all we need is a means to:
1) list all tests in a testsuite
2) initiate running each test individually

Mike

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel