All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, "Yanan Wang" <wangyanan55@huawei.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Leonardo Bras" <leobras@redhat.com>
Subject: Re: [PATCH v8 0/3] Eliminate multifd flush
Date: Tue, 25 Apr 2023 14:49:10 -0400	[thread overview]
Message-ID: <ZEggpionTpImHcQu@x1n> (raw)
In-Reply-To: <20230425163114.2609-1-quintela@redhat.com>

On Tue, Apr 25, 2023 at 06:31:11PM +0200, Juan Quintela wrote:
> Hi
> 
> In this v8:
> - rebase over latests

One trivial comment for patch 1 on the compat bits, for patch 2-3:

Acked-by: Peter Xu <peterx@redhat.com>

Nit: I still think we should just squash the three patches into one, but
I'm fine either way.

Thanks,

-- 
Peter Xu



      parent reply	other threads:[~2023-04-25 18:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 16:31 [PATCH v8 0/3] Eliminate multifd flush Juan Quintela
2023-04-25 16:31 ` [PATCH v8 1/3] multifd: Create property multifd-flush-after-each-section Juan Quintela
2023-04-25 18:42   ` Peter Xu
2023-04-26 16:55     ` Juan Quintela
2023-04-25 16:31 ` [PATCH v8 2/3] multifd: Protect multifd_send_sync_main() calls Juan Quintela
2023-04-25 16:31 ` [PATCH v8 3/3] multifd: Only flush once each full round of memory Juan Quintela
2023-04-25 18:49 ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZEggpionTpImHcQu@x1n \
    --to=peterx@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=leobras@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.