From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: tb/ban-strtok (was: Re: What's cooking in git.git (Apr 2023, #07; Tue, 25))
Date: Wed, 26 Apr 2023 19:34:47 -0400 [thread overview]
Message-ID: <ZEm1F78kF7rMWyFb@nand.local> (raw)
In-Reply-To: <xmqq354nxzqr.fsf@gitster.g>
On Tue, Apr 25, 2023 at 05:18:20PM -0700, Junio C Hamano wrote:
> * tb/ban-strtok (2023-04-24) 6 commits
> - banned.h: mark `strtok()` and `strtok_r()` as banned
> - t/helper/test-json-writer.c: avoid using `strtok()`
> - t/helper/test-oidmap.c: avoid using `strtok()`
> - t/helper/test-hashmap.c: avoid using `strtok()`
> - string-list: introduce `string_list_setlen()`
> - string-list: multi-delimiter `string_list_split_in_place()`
>
> Mark strtok() and strtok_r() to be banned.
> source: <cover.1682374789.git.me@ttaylorr.com>
This one is ready to go. Peff took a look[1] over the latest version and
I think we both agree it's in a good place.
Thanks,
Taylor
[1]: https://lore.kernel.org/git/20230425062708.GC4061254@coredump.intra.peff.net/
prev parent reply other threads:[~2023-04-26 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 0:18 What's cooking in git.git (Apr 2023, #07; Tue, 25) Junio C Hamano
2023-04-26 22:16 ` gc/doc-cocci-updates (Re: What's cooking in git.git (Apr 2023, #07; Tue, 25)) Glen Choo
2023-04-26 23:34 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEm1F78kF7rMWyFb@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.