From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Chao Yu <chao@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: remove some dead code
Date: Thu, 27 Apr 2023 09:28:00 -0700 [thread overview]
Message-ID: <ZEqikAnNmjMxuSoU@google.com> (raw)
In-Reply-To: <2867d5b3-c6cb-49fa-854a-0f58f9a5adb5@kili.mountain>
On 04/18, Dan Carpenter wrote:
> On Mon, Apr 17, 2023 at 10:51:46PM +0200, Christophe JAILLET wrote:
> >
> > - ret2 = filemap_check_errors(NODE_MAPPING(sbi));
> > - if (!ret)
> > - ret = ret2;
> > + ret = filemap_check_errors(NODE_MAPPING(sbi));
> >
> > return ret;
>
> Let's get rid of "ret" as well:
>
> return filemap_check_errors(NODE_MAPPING(sbi));
Applied with this modification. Thanks.
>
> regards,
> dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Dan Carpenter <error27@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: remove some dead code
Date: Thu, 27 Apr 2023 09:28:00 -0700 [thread overview]
Message-ID: <ZEqikAnNmjMxuSoU@google.com> (raw)
In-Reply-To: <2867d5b3-c6cb-49fa-854a-0f58f9a5adb5@kili.mountain>
On 04/18, Dan Carpenter wrote:
> On Mon, Apr 17, 2023 at 10:51:46PM +0200, Christophe JAILLET wrote:
> >
> > - ret2 = filemap_check_errors(NODE_MAPPING(sbi));
> > - if (!ret)
> > - ret = ret2;
> > + ret = filemap_check_errors(NODE_MAPPING(sbi));
> >
> > return ret;
>
> Let's get rid of "ret" as well:
>
> return filemap_check_errors(NODE_MAPPING(sbi));
Applied with this modification. Thanks.
>
> regards,
> dan carpenter
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-04-27 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 20:51 [PATCH] f2fs: remove some dead code Christophe JAILLET
2023-04-17 20:51 ` [f2fs-dev] " Christophe JAILLET
2023-04-18 4:43 ` Dan Carpenter
2023-04-18 4:43 ` [f2fs-dev] " Dan Carpenter
2023-04-27 16:28 ` Jaegeuk Kim [this message]
2023-04-27 16:28 ` Jaegeuk Kim
2023-04-28 1:01 ` Chao Yu
2023-04-28 1:01 ` [f2fs-dev] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEqikAnNmjMxuSoU@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.