From: Tao Su <tao1.su@linux.intel.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
tj@kernel.org, josef@toxicpanda.com, yukuai1@huaweicloud.com
Subject: Re: [PATCH v2] block: Skip destroyed blkg when restart in blkg_destroy_all()
Date: Sat, 29 Apr 2023 15:10:12 +0800 [thread overview]
Message-ID: <ZEzC1BAX7e7t8Jaj@linux.bj.intel.com> (raw)
In-Reply-To: <168270266088.259022.9566325777722187933.b4-ty@kernel.dk>
On Fri, Apr 28, 2023 at 11:24:20AM -0600, Jens Axboe wrote:
>
> On Fri, 28 Apr 2023 12:51:49 +0800, Tao Su wrote:
> > Kernel hang in blkg_destroy_all() when total blkg greater than
> > BLKG_DESTROY_BATCH_SIZE, because of not removing destroyed blkg in
> > blkg_list. So the size of blkg_list is same after destroying a
> > batch of blkg, and the infinite 'restart' occurs.
> >
> > Since blkg should stay on the queue list until blkg_free_workfn(),
> > skip destroyed blkg when restart a new round, which will solve this
> > kernel hang issue and satisfy the previous will to restart.
> >
> > [...]
>
> Applied, thanks!
Axboe, thanks!
Tao
>
> [1/1] block: Skip destroyed blkg when restart in blkg_destroy_all()
> commit: 8176080d59e6d4ff9fc97ae534063073b4f7a715
>
> Best regards,
> --
> Jens Axboe
>
>
>
prev parent reply other threads:[~2023-04-29 7:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 4:51 [PATCH v2] block: Skip destroyed blkg when restart in blkg_destroy_all() Tao Su
2023-04-28 6:12 ` Yu Kuai
2023-04-28 6:49 ` Tao Su
2023-04-28 17:24 ` Jens Axboe
2023-04-29 7:10 ` Tao Su [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEzC1BAX7e7t8Jaj@linux.bj.intel.com \
--to=tao1.su@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.